You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "porcelli (via GitHub)" <gi...@apache.org> on 2025/01/06 17:41:14 UTC

[PR] Adding support for DMN 1.5 for maven plugin code-gen [incubator-kie-kogito-runtimes]

porcelli opened a new pull request, #3823:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823

   Closes: https://github.com/apache/incubator-kie-issues/issues/1740
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Fix usage of DMN 1.5 for tracing-enabled applications inside maven plugin code-gen [incubator-kie-kogito-runtimes]

Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli merged PR #3823:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Adding support for DMN 1.5 for maven plugin code-gen [incubator-kie-kogito-runtimes]

Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3823:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#discussion_r1905453988


##########
kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn:
##########
@@ -1,24 +1,6 @@
-<!--
-  ~ Licensed to the Apache Software Foundation (ASF) under one
-  ~ or more contributor license agreements.  See the NOTICE file
-  ~ distributed with this work for additional information
-  ~ regarding copyright ownership.  The ASF licenses this file
-  ~ to you under the Apache License, Version 2.0 (the
-  ~ "License"); you may not use this file except in compliance
-  ~ with the License.  You may obtain a copy of the License at
-  ~
-  ~   http://www.apache.org/licenses/LICENSE-2.0
-  ~
-  ~ Unless required by applicable law or agreed to in writing,
-  ~ software distributed under the License is distributed on an
-  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-  ~ KIND, either express or implied.  See the License for the
-  ~ specific language governing permissions and limitations
-  ~ under the License.
-  -->
-
-<dmn:definitions xmlns:dmn="http://www.omg.org/spec/DMN/20180521/MODEL/" xmlns="decision" xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" xmlns:kie="http://www.drools.org/kie/dmn/1.2" xmlns:dmndi="http://www.omg.org/spec/DMN/20180521/DMNDI/" xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/" xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/" id="_9efe7fc6-f41b-422c-accd-95dcaaa67a39" name="Vacations" typeLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/" namespace="decision">
-  <dmn:extensionElements/>
+<?xml version="1.0" encoding="UTF-8" ?>

Review Comment:
   @gitgabrio @porcelli @jomarko Indeed we need to investigate this, as far as I know, the prolog should be correctly validated. When creating a new dmn file in our editor, the prolog is automatically added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Fix usage of DMN 1.5 for tracing-enabled applications inside maven plugin code-gen [incubator-kie-kogito-runtimes]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on PR #3823:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#issuecomment-2579755196

   Thanks @porcelli !
   Anyway, I can't understand why the kogito-runtimes build is marked as failed - the tests seems all succeeding 🤔 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Adding support for DMN 1.5 for maven plugin code-gen [incubator-kie-kogito-runtimes]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #3823:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#discussion_r1905048559


##########
kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn:
##########
@@ -1,24 +1,6 @@
-<!--
-  ~ Licensed to the Apache Software Foundation (ASF) under one
-  ~ or more contributor license agreements.  See the NOTICE file
-  ~ distributed with this work for additional information
-  ~ regarding copyright ownership.  The ASF licenses this file
-  ~ to you under the Apache License, Version 2.0 (the
-  ~ "License"); you may not use this file except in compliance
-  ~ with the License.  You may obtain a copy of the License at
-  ~
-  ~   http://www.apache.org/licenses/LICENSE-2.0
-  ~
-  ~ Unless required by applicable law or agreed to in writing,
-  ~ software distributed under the License is distributed on an
-  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-  ~ KIND, either express or implied.  See the License for the
-  ~ specific language governing permissions and limitations
-  ~ under the License.
-  -->
-
-<dmn:definitions xmlns:dmn="http://www.omg.org/spec/DMN/20180521/MODEL/" xmlns="decision" xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" xmlns:kie="http://www.drools.org/kie/dmn/1.2" xmlns:dmndi="http://www.omg.org/spec/DMN/20180521/DMNDI/" xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/" xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/" id="_9efe7fc6-f41b-422c-accd-95dcaaa67a39" name="Vacations" typeLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/" namespace="decision">
-  <dmn:extensionElements/>
+<?xml version="1.0" encoding="UTF-8" ?>

Review Comment:
   HI @porcelli 
   Thanks for PR! 
   As @jomarko pointed out, the
   `xml` tag has to be removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Fix usage of DMN 1.5 for tracing-enabled applications inside maven plugin code-gen [incubator-kie-kogito-runtimes]

Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on PR #3823:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#issuecomment-2582827059

   @porcelli @gitgabrio 
   Here the failure's reason
   
   ```
   2025-01-09T13:36:26.6605040Z [ERROR] Failed to execute goal net.revelc.code:impsort-maven-plugin:1.8.0:check (default) on project kogito-codegen-decisions: Imports are not sorted in /home/runner/work/incubator-kie-kogito-runtimes/incubator-kie-kogito-runtimes/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/main/java/org/kie/kogito/codegen/decision/DecisionModelResourcesProviderGenerator.java -> [Help 1]
   2025-01-09T13:36:26.6611113Z org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal net.revelc.code:impsort-maven-plugin:1.8.0:check (default) on project kogito-codegen-decisions: Imports are not sorted in /home/runner/work/incubator-kie-kogito-runtimes/incubator-kie-kogito-runtimes/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/main/java/org/kie/kogito/codegen/decision/DecisionModelResourcesProviderGenerator.java
   ```
   
   Weird, as there are no new imported classes in DecisionModelResourcesProviderGenerator.java, maybe there's an unused import?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Adding support for DMN 1.5 for maven plugin code-gen [incubator-kie-kogito-runtimes]

Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #3823:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#issuecomment-2573776241

   
   **PR job** `#1` was: **UNSTABLE**
   Possible explanation: This should be test failures
   
   
   <details>
   <summary><b>Reproducer</b></summary>
   
   
   
   build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823 --skipParallelCheckout
   
   NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
   
   </details>
   
   
   Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/display/redirect
   
   **Test results:**
   - PASSED: 3506
   - FAILED: 18
   
   Those are the test failures: 
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCloudEventMetaFactoryGeneratorTest/testGenerateWithCloudEventsDisabled/">org.kie.kogito.codegen.decision.DecisionCloudEventMetaFactoryGeneratorTest.testGenerateWithCloudEventsDisabled</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCloudEventMetaFactoryGeneratorTest/testGenerateWithCloudEventsEnabled/">org.kie.kogito.codegen.decision.DecisionCloudEventMetaFactoryGeneratorTest.testGenerateWithCloudEventsEnabled</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCodegenTest/generateAllFiles(Builder)[1]/">org.kie.kogito.codegen.decision.DecisionCodegenTest.generateAllFiles(Builder)[1]</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCodegenTest/generateAllFiles(Builder)[2]/">org.kie.kogito.codegen.decision.DecisionCodegenTest.generateAllFiles(Builder)[2]</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCodegenTest/generateAllFiles(Builder)[3]/">org.kie.kogito.codegen.decision.DecisionCodegenTest.generateAllFiles(Builder)[3]</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCodegenTest/givenADMNModelWhenMonitoringIsActiveButDashboardsDeactivatedThenGrafanaDashboardsAreNotGenerated(Builder)[1]/">org.kie.kogito.codegen.decision.DecisionCodegenTest.givenADMNModelWhenMonitoringIsActiveButDashboardsDeactivatedThenGrafanaDashboardsAreNotGenerated(Builder)[1]</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCodegenTest/givenADMNModelWhenMonitoringIsActiveButDashboardsDeactivatedThenGrafanaDashboardsAreNotGenerated(Builder)[2]/">org.kie.kogito.codegen.decision.DecisionCodegenTest.givenADMNModelWhenMonitoringIsActiveButDashboardsDeactivatedThenGrafanaDashboardsAreNotGenerated(Builder)[2]</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCodegenTest/givenADMNModelWhenMonitoringIsActiveButDashboardsDeactivatedThenGrafanaDashboardsAreNotGenerated(Builder)[3]/">org.kie.kogito.codegen.decision.DecisionCodegenTest.givenADMNModelWhenMonitoringIsActiveButDashboardsDeactivatedThenGrafanaDashboardsAreNotGenerated(Builder)[3]</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCodegenTest/givenADMNModelWhenMonitoringIsActiveThenGrafanaDashboardsAreGenerated(Builder)[1]/">org.kie.kogito.codegen.decision.DecisionCodegenTest.givenADMNModelWhenMonitoringIsActiveThenGrafanaDashboardsAreGenerated(Builder)[1]</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCodegenTest/givenADMNModelWhenMonitoringIsActiveThenGrafanaDashboardsAreGenerated(Builder)[2]/">org.kie.kogito.codegen.decision.DecisionCodegenTest.givenADMNModelWhenMonitoringIsActiveThenGrafanaDashboardsAreGenerated(Builder)[2]</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCodegenTest/givenADMNModelWhenMonitoringIsActiveThenGrafanaDashboardsAreGenerated(Builder)[3]/">org.kie.kogito.codegen.decision.DecisionCodegenTest.givenADMNModelWhenMonitoringIsActiveThenGrafanaDashboardsAreGenerated(Builder)[3]</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCodegenTest/givenADMNModelWhenMonitoringAndTracingAreActiveThenTheGrafanaDashboardsContainsTheAuditUILink(Builder)[1]/">org.kie.kogito.codegen.decision.DecisionCodegenTest.givenADMNModelWhenMonitoringAndTracingAreActiveThenTheGrafanaDashboardsContainsTheAuditUILink(Builder)[1]</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCodegenTest/givenADMNModelWhenMonitoringAndTracingAreActiveThenTheGrafanaDashboardsContainsTheAuditUILink(Builder)[2]/">org.kie.kogito.codegen.decision.DecisionCodegenTest.givenADMNModelWhenMonitoringAndTracingAreActiveThenTheGrafanaDashboardsContainsTheAuditUILink(Builder)[2]</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCodegenTest/givenADMNModelWhenMonitoringAndTracingAreActiveThenTheGrafanaDashboardsContainsTheAuditUILink(Builder)[3]/">org.kie.kogito.codegen.decision.DecisionCodegenTest.givenADMNModelWhenMonitoringAndTracingAreActiveThenTheGrafanaDashboardsContainsTheAuditUILink(Builder)[3]</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCodegenTest/isEmpty(Builder)[1]/">org.kie.kogito.codegen.decision.DecisionCodegenTest.isEmpty(Builder)[1]</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCodegenTest/isEmpty(Builder)[2]/">org.kie.kogito.codegen.decision.DecisionCodegenTest.isEmpty(Builder)[2]</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCodegenTest/isEmpty(Builder)[3]/">org.kie.kogito.codegen.decision.DecisionCodegenTest.isEmpty(Builder)[3]</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionModelResourcesProviderGeneratorTest/generateDecisionModelResourcesProvider/">org.kie.kogito.codegen.decision.DecisionModelResourcesProviderGeneratorTest.generateDecisionModelResourcesProvider</a></summary>
   DMN Validation schema and model validation contained errors<br/>You may configure kogito.decisions.validation=IGNORE to ignore validation errors<br/>DMN Validation errors:<br/>: DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,<br/>: DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) 
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Adding support for DMN 1.5 for maven plugin code-gen [incubator-kie-kogito-runtimes]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #3823:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#discussion_r1905048559


##########
kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn:
##########
@@ -1,24 +1,6 @@
-<!--
-  ~ Licensed to the Apache Software Foundation (ASF) under one
-  ~ or more contributor license agreements.  See the NOTICE file
-  ~ distributed with this work for additional information
-  ~ regarding copyright ownership.  The ASF licenses this file
-  ~ to you under the Apache License, Version 2.0 (the
-  ~ "License"); you may not use this file except in compliance
-  ~ with the License.  You may obtain a copy of the License at
-  ~
-  ~   http://www.apache.org/licenses/LICENSE-2.0
-  ~
-  ~ Unless required by applicable law or agreed to in writing,
-  ~ software distributed under the License is distributed on an
-  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-  ~ KIND, either express or implied.  See the License for the
-  ~ specific language governing permissions and limitations
-  ~ under the License.
-  -->
-
-<dmn:definitions xmlns:dmn="http://www.omg.org/spec/DMN/20180521/MODEL/" xmlns="decision" xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" xmlns:kie="http://www.drools.org/kie/dmn/1.2" xmlns:dmndi="http://www.omg.org/spec/DMN/20180521/DMNDI/" xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/" xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/" id="_9efe7fc6-f41b-422c-accd-95dcaaa67a39" name="Vacations" typeLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/" namespace="decision">
-  <dmn:extensionElements/>
+<?xml version="1.0" encoding="UTF-8" ?>

Review Comment:
   HI @porcelli 
   Thanks for PR! 
   As @jomarko pointed out, the
   `?xml` tag has to be removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Fix usage of DMN 1.5 for tracing-enabled applications inside maven plugin code-gen [incubator-kie-kogito-runtimes]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on PR #3823:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#issuecomment-2582941811

   Thanks @yesamer  👏 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Adding support for DMN 1.5 for maven plugin code-gen [incubator-kie-kogito-runtimes]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.
jomarko commented on code in PR #3823:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#discussion_r1905034916


##########
kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn:
##########
@@ -16,9 +16,9 @@
   ~ specific language governing permissions and limitations
   ~ under the License.
   -->
-
-<dmn:definitions xmlns:dmn="http://www.omg.org/spec/DMN/20180521/MODEL/" xmlns="decision" xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" xmlns:kie="http://www.drools.org/kie/dmn/1.2" xmlns:dmndi="http://www.omg.org/spec/DMN/20180521/DMNDI/" xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/" xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/" id="_9efe7fc6-f41b-422c-accd-95dcaaa67a39" name="Vacations" typeLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/" namespace="decision">
-  <dmn:extensionElements/>
+<?xml version="1.0" encoding="UTF-8" ?>

Review Comment:
   failed tests seems to be related to this :
   ```
   DMN Validation schema and model validation contained errors
   You may configure kogito.decisions.validation=IGNORE to ignore validation errors
   DMN Validation errors:
   : DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) ,
   : DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Fix usage of DMN 1.5 for tracing-enabled applications inside maven plugin code-gen [incubator-kie-kogito-runtimes]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #3823:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#discussion_r1905554115


##########
kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn:
##########
@@ -1,24 +1,6 @@
-<!--
-  ~ Licensed to the Apache Software Foundation (ASF) under one
-  ~ or more contributor license agreements.  See the NOTICE file
-  ~ distributed with this work for additional information
-  ~ regarding copyright ownership.  The ASF licenses this file
-  ~ to you under the Apache License, Version 2.0 (the
-  ~ "License"); you may not use this file except in compliance
-  ~ with the License.  You may obtain a copy of the License at
-  ~
-  ~   http://www.apache.org/licenses/LICENSE-2.0
-  ~
-  ~ Unless required by applicable law or agreed to in writing,
-  ~ software distributed under the License is distributed on an
-  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-  ~ KIND, either express or implied.  See the License for the
-  ~ specific language governing permissions and limitations
-  ~ under the License.
-  -->
-
-<dmn:definitions xmlns:dmn="http://www.omg.org/spec/DMN/20180521/MODEL/" xmlns="decision" xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" xmlns:kie="http://www.drools.org/kie/dmn/1.2" xmlns:dmndi="http://www.omg.org/spec/DMN/20180521/DMNDI/" xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/" xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/" id="_9efe7fc6-f41b-422c-accd-95dcaaa67a39" name="Vacations" typeLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/" namespace="decision">
-  <dmn:extensionElements/>
+<?xml version="1.0" encoding="UTF-8" ?>

Review Comment:
   Ok, just double checked, the "?xml" tag should be before the license header, as very first line.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Adding support for DMN 1.5 for maven plugin code-gen [incubator-kie-kogito-runtimes]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on PR #3823:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#issuecomment-2575261505

   @porcelli 
   On deeper analysis, the problem is that the
   1.  the "extractModelVersion(DMNResource resource)" method should not exists at all, and it is invoked only on a very specific case
   2. the implementation is anyway conceptually completely "wrong", and should simply return
   
   `resource.getDmnModel().getDefinitions().getTypeLanguage()`
   
   (no need of anything else, apparently)
   
   @baldimir  @yesamer FYI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Fix usage of DMN 1.5 for tracing-enabled applications inside maven plugin code-gen [incubator-kie-kogito-runtimes]

Posted by "baldimir (via GitHub)" <gi...@apache.org>.
baldimir commented on code in PR #3823:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#discussion_r1905537566


##########
kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn:
##########
@@ -1,24 +1,6 @@
-<!--
-  ~ Licensed to the Apache Software Foundation (ASF) under one
-  ~ or more contributor license agreements.  See the NOTICE file
-  ~ distributed with this work for additional information
-  ~ regarding copyright ownership.  The ASF licenses this file
-  ~ to you under the Apache License, Version 2.0 (the
-  ~ "License"); you may not use this file except in compliance
-  ~ with the License.  You may obtain a copy of the License at
-  ~
-  ~   http://www.apache.org/licenses/LICENSE-2.0
-  ~
-  ~ Unless required by applicable law or agreed to in writing,
-  ~ software distributed under the License is distributed on an
-  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-  ~ KIND, either express or implied.  See the License for the
-  ~ specific language governing permissions and limitations
-  ~ under the License.
-  -->
-
-<dmn:definitions xmlns:dmn="http://www.omg.org/spec/DMN/20180521/MODEL/" xmlns="decision" xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" xmlns:kie="http://www.drools.org/kie/dmn/1.2" xmlns:dmndi="http://www.omg.org/spec/DMN/20180521/DMNDI/" xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/" xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/" id="_9efe7fc6-f41b-422c-accd-95dcaaa67a39" name="Vacations" typeLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/" namespace="decision">
-  <dmn:extensionElements/>
+<?xml version="1.0" encoding="UTF-8" ?>

Review Comment:
   Yes, should be there. It is also part of e.g. DMN TCK test files, like e.g. here (1).
   
   (1) https://github.com/dmn-tck/tck/blob/master/TestCases/compliance-level-3/0007-date-time/0007-date-time.dmn#L1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Fix usage of DMN 1.5 for tracing-enabled applications inside maven plugin code-gen [incubator-kie-kogito-runtimes]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on PR #3823:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#issuecomment-2575473257

   @porcelli 
   
   Could you pls try with:
   
   
   ```java
   private String extractModelVersion(DMNResource resource) {
           String toReturn = resource.getDmnModel().getDefinitions().getTypeLanguage();
           if (toReturn == null || toReturn.isEmpty()) {
               LOGGER.error("Could not extract DMN version from DMN model {}", resource.getDmnModel().getName());
               throw new IllegalStateException("The DMN model does not contain a unique model version in the metadata.");
           }
           return toReturn;
       }
       ```
       
       so that the CI will check it also downstream ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org