[jira] [Commented] (DRILL-2462) JDBC : ResultSetMetaData.isNullable returns true even when the column is a required one

["Daniel Barclay (Drill) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573765#comment-14573765 ] 

Daniel Barclay (Drill) commented on DRILL-2462:
-----------------------------------------------

Is this really critical?

If isNullable(...) incorrectly returned false for a nullable column, it's easy to see how that could lead a tool to assume there are no nulls, dereference a null, and crash.

However, if isNullable(...) incorrectly returns true for a non-nullable column, it's not obvious that that is a critical problem.  (A tool assuming that there are some nulls still has to handle non-null values, so never actually getting a null seems like a lower-priority problem.)



> JDBC : ResultSetMetaData.isNullable returns true even when the column is a required one
> ---------------------------------------------------------------------------------------
>
>                 Key: DRILL-2462
>                 URL: https://issues.apache.org/jira/browse/DRILL-2462
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - JDBC
>            Reporter: Rahul Challapalli
>            Assignee: Daniel Barclay (Drill)
>            Priority: Critical
>             Fix For: 1.1.0
>
>         Attachments: fewtypes.parquet
>
>
> git.commit.id.abbrev=7b4c887
> I attached a parquet file in which all the columns are required
> {code}
> /root/parquet-tools-1.5.1-SNAPSHOT/parquet-tools schema fewtypes.parquet
> message root {
>   required int32 int_col;
>   required int64 bigint_col;
>   required int32 date_col (DATE);
>   required int32 time_col (TIME);
>   required int64 timestamp_col (TIMESTAMP);
>   required binary interval_col (UTF8);
>   required binary varchar_col (UTF8);
>   required float float_col;
>   required double double_col;
>   required boolean bool_col;
> }
> {code}
> However ResultSetMetaData.isNullable returns true for these columns.
> Let me know if you need anythig



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)