You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/05/25 18:28:58 UTC
[GitHub] [incubator-pinot] sajjad-moradi opened a new pull request #6974: Revert deep store directory structure changes after introducing upsert
sajjad-moradi opened a new pull request #6974:
URL: https://github.com/apache/incubator-pinot/pull/6974
## Description
This PR is the fix for the issue described in #6966. Basically it reverts the changes recently made to deep store directory structure.
## Testing Done
Deployed locally and verified that segments are created in `tableName/segmentName` directory structure instead of the current problematic directory structure `tableName_OFFLINE/segmentName`. Also segmentDownloadUrl in segment ZKMetadata points to the desired directory. Tested it with an offline table and also a hybrid table to validated both realtime and offline segments. The query execution is also fine for both offline and realtime scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] snleee commented on pull request #6974: Revert deep store directory structure changes after introducing upsert
Posted by GitBox <gi...@apache.org>.
snleee commented on pull request #6974:
URL: https://github.com/apache/incubator-pinot/pull/6974#issuecomment-848115394
Have we decided to roll-back the entire commit? I thought we are going to fix forward by replacing the part that got inadvertently swicthed to `rawTableName` to `tableNameWithType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] chenboat commented on pull request #6974: Revert deep store directory structure changes after introducing upsert
Posted by GitBox <gi...@apache.org>.
chenboat commented on pull request #6974:
URL: https://github.com/apache/incubator-pinot/pull/6974#issuecomment-848315156
Is this PR intended to be merged to Master? @sajjad-moradi ? Just saw @snleee merged this PR to another branch.
How about filing a PR to fix forward in the master branch? I am working on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] snleee merged pull request #6974: Revert deep store directory structure changes after introducing upsert
Posted by GitBox <gi...@apache.org>.
snleee merged pull request #6974:
URL: https://github.com/apache/incubator-pinot/pull/6974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org