[jira] [Comment Edited] (TS-3152) We offer up H2-14 on current master, even when it's not working / supported

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182366#comment-14182366 ] 

Leif Hedstrom edited comment on TS-3152 at 10/24/14 3:08 AM:
-------------------------------------------------------------

Hmmm, I guess I don't understand the issue here. The docs say, and I agree with that, that if I just specify "ssl", it'll use all supported protocols. What I had expected to happen is this:

1) If I compile with SPDY enabled, it would then offer SPDY, unless I tell it not to.

1.5) If I don't compile with SPDY, it would never offer SPDY, no matter what the config.

2) If I compile it with H2 enabled, it would then offer H2, unless I tell it not to.

2.5) If I don't compile with H2, it would never offer H2, no matter what the config.


Having to manually enable these things both at compile time and then again at config time seems annoying at best, and probably even confusing. I'd venture a guess that if you compile with e.g. SPDY support, you want that to be on by default.



was (Author: zwoop):
Hmmm, I guess I don't understand the issue here. The docs say, and I agree with that, that if I just specify "ssl", it'll use all supported protocols. What I had expected to happen is this:

1) If I compile with SPDY enabled, it would then offer SPDY, unless I tell it not to.

2) If I compile it with H2 enabled, it would then offer H2, unless I tell it not to.


Having to manually enable these things both at compile time and then again at config time seems annoying at best, and probably even confusing. I'd venture a guess that if you compile with e.g. SPDY support, you want that to be on by default.


> We offer up H2-14 on current master, even when it's not working / supported
> ---------------------------------------------------------------------------
>
>                 Key: TS-3152
>                 URL: https://issues.apache.org/jira/browse/TS-3152
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP/2
>            Reporter: Leif Hedstrom
>            Assignee: Alan M. Carroll
>             Fix For: 5.2.0
>
>         Attachments: TS-3152.diff
>
>
> E.g.
> {code}
> [root@ats ~]#  /usr/local/bin/nghttp  -v https://www.ogre.com
> [  0.112][NPN] server offers:
>           * spdy/3.1
>           * spdy/3
>           * h2-14
>           * http/1.1
>           * http/1.0
> The negotiated protocol: h2-14
> ...
> [  0.156] send SETTINGS frame <length=0, flags=0x01, stream_id=0>
>           ; ACK
>           (niv=0)
> [ERROR] Network error
> Some requests were not processed. total=1, processed=0
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)