You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Mamta A. Satoor (JIRA)" <ji...@apache.org> on 2007/04/09 20:29:33 UTC
[jira] Created: (DERBY-2535) Make Locale available in
DataValueFactory(DVF). This Locale object will be used to construct
Collator object if the user has requested territory based collation.
Make Locale available in DataValueFactory(DVF). This Locale object will be used to construct Collator object if the user has requested territory based collation.
-----------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: DERBY-2535
URL: https://issues.apache.org/jira/browse/DERBY-2535
Project: Derby
Issue Type: New Feature
Components: SQL
Affects Versions: 10.3.0.0
Reporter: Mamta A. Satoor
Assigned To: Mamta A. Satoor
Add a new api on DVF which will make Locale object available to DVF. This new api on DVF will get called by the boot method of BasicDatabase after BasicDatabase has finished booting DVF. This Locale will be either the Locale obtained from the territory attribute supplied by the user on the JDBC url at database create time or if user didn't provide the territory attribute at database create time, then it will be set to the default JVM locale. This Locale object will be used by DVF to construct the Collator object if user has requested territory based collation.
The new api will look like following
void setLocale(Locale localeOfTheDatabase);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2535) Make Locale available in
DataValueFactory(DVF). This Locale object will be used to construct
Collator object if the user has requested territory based collation.
Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487686 ]
Mamta A. Satoor commented on DERBY-2535:
----------------------------------------
Committed patch DERBY2535_Set_Locale_On_DVF_v1_diff.txt as part of revision 527034
> Make Locale available in DataValueFactory(DVF). This Locale object will be used to construct Collator object if the user has requested territory based collation.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2535
> URL: https://issues.apache.org/jira/browse/DERBY-2535
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2535_Set_Locale_On_DVF_v1_diff.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt
>
>
> Add a new api on DVF which will make Locale object available to DVF. This new api on DVF will get called by the boot method of BasicDatabase after BasicDatabase has finished booting DVF. This Locale will be either the Locale obtained from the territory attribute supplied by the user on the JDBC url at database create time or if user didn't provide the territory attribute at database create time, then it will be set to the default JVM locale. This Locale object will be used by DVF to construct the Collator object if user has requested territory based collation.
> The new api will look like following
> void setLocale(Locale localeOfTheDatabase);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2535) Make Locale available in
DataValueFactory(DVF). This Locale object will be used to construct
Collator object if the user has requested territory based collation.
Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mamta A. Satoor updated DERBY-2535:
-----------------------------------
Attachment: DERBY2535_Set_Locale_On_DVF_v1_stat.txt
DERBY2535_Set_Locale_On_DVF_v1_diff.txt
Attaching a simple patch which will set a Locale object in DVF. This setting of Locale in DVF will be done by BasicDatabase after it has finished booting DVF. DVF will use the Locale object to construct Collator if user requested territory based collation.
> Make Locale available in DataValueFactory(DVF). This Locale object will be used to construct Collator object if the user has requested territory based collation.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2535
> URL: https://issues.apache.org/jira/browse/DERBY-2535
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2535_Set_Locale_On_DVF_v1_diff.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt
>
>
> Add a new api on DVF which will make Locale object available to DVF. This new api on DVF will get called by the boot method of BasicDatabase after BasicDatabase has finished booting DVF. This Locale will be either the Locale obtained from the territory attribute supplied by the user on the JDBC url at database create time or if user didn't provide the territory attribute at database create time, then it will be set to the default JVM locale. This Locale object will be used by DVF to construct the Collator object if user has requested territory based collation.
> The new api will look like following
> void setLocale(Locale localeOfTheDatabase);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2535) Make Locale available in
DataValueFactory(DVF). This Locale object will be used to construct
Collator object if the user has requested territory based collation.
Posted by "A B (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487845 ]
A B commented on DERBY-2535:
----------------------------
Thank you for the quick explanation, Mamta. Do you think it would be worth it to add a comment saying this to the GenericLanguageConnectionFactory.boot() method? This certainly isn't a requirement, just a suggestion.
Either way, thanks again for answering my question :)
> Make Locale available in DataValueFactory(DVF). This Locale object will be used to construct Collator object if the user has requested territory based collation.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2535
> URL: https://issues.apache.org/jira/browse/DERBY-2535
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2535_Set_Locale_On_DVF_v1_diff.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Uncomment_locale_setting_on_DVF_v1_diff.txt
>
>
> Add a new api on DVF which will make Locale object available to DVF. This new api on DVF will get called by the boot method of BasicDatabase after BasicDatabase has finished booting DVF. This Locale will be either the Locale obtained from the territory attribute supplied by the user on the JDBC url at database create time or if user didn't provide the territory attribute at database create time, then it will be set to the default JVM locale. This Locale object will be used by DVF to construct the Collator object if user has requested territory based collation.
> The new api will look like following
> void setLocale(Locale localeOfTheDatabase);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2535) Make Locale available in
DataValueFactory(DVF). This Locale object will be used to construct
Collator object if the user has requested territory based collation.
Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487598 ]
Mamta A. Satoor commented on DERBY-2535:
----------------------------------------
The attached patch (DERBY2535_Set_Locale_On_DVF_v1_diff.txt) changes following files
svn stat -q
M java\engine\org\apache\derby\impl\db\BasicDatabase.java
M java\engine\org\apache\derby\iapi\types\DataValueFactoryImpl.java
M java\engine\org\apache\derby\iapi\types\DataValueFactory.java
I have fired the tests but do not anticipate anything failing because BasicDatabase just sets the Locale on DVF. Will soon commit this patch.
> Make Locale available in DataValueFactory(DVF). This Locale object will be used to construct Collator object if the user has requested territory based collation.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2535
> URL: https://issues.apache.org/jira/browse/DERBY-2535
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2535_Set_Locale_On_DVF_v1_diff.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt
>
>
> Add a new api on DVF which will make Locale object available to DVF. This new api on DVF will get called by the boot method of BasicDatabase after BasicDatabase has finished booting DVF. This Locale will be either the Locale obtained from the territory attribute supplied by the user on the JDBC url at database create time or if user didn't provide the territory attribute at database create time, then it will be set to the default JVM locale. This Locale object will be used by DVF to construct the Collator object if user has requested territory based collation.
> The new api will look like following
> void setLocale(Locale localeOfTheDatabase);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2535) Make Locale available in
DataValueFactory(DVF). This Locale object will be used to construct
Collator object if the user has requested territory based collation.
Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487855 ]
Mamta A. Satoor commented on DERBY-2535:
----------------------------------------
Army, I was already working on writing the comments in GenericLanguageConnectionFactory. So, yes, I will commit the comment changes in another few minutes.
> Make Locale available in DataValueFactory(DVF). This Locale object will be used to construct Collator object if the user has requested territory based collation.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2535
> URL: https://issues.apache.org/jira/browse/DERBY-2535
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2535_Set_Locale_On_DVF_v1_diff.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Uncomment_locale_setting_on_DVF_v1_diff.txt
>
>
> Add a new api on DVF which will make Locale object available to DVF. This new api on DVF will get called by the boot method of BasicDatabase after BasicDatabase has finished booting DVF. This Locale will be either the Locale obtained from the territory attribute supplied by the user on the JDBC url at database create time or if user didn't provide the territory attribute at database create time, then it will be set to the default JVM locale. This Locale object will be used by DVF to construct the Collator object if user has requested territory based collation.
> The new api will look like following
> void setLocale(Locale localeOfTheDatabase);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2535) Make Locale available in
DataValueFactory(DVF). This Locale object will be used to construct
Collator object if the user has requested territory based collation.
Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488466 ]
Mamta A. Satoor commented on DERBY-2535:
----------------------------------------
My earlier comment (that I just deleted) used incorrect terminology for what classes were involved in the patch(DERBY2535_Return_Collator_api_On_DVD_v1_diff.txt ) and what the exact changes were. Here is the correct comment for the patch that I just commited as revision 528070.
Description of patch DERBY2535_Return_Collator_api_On_DVD_v1_diff.txt.
This patch adds a new api on DataValueFactory(DVF) to return the Collator object depending on the collation type. The new api looks as follows
RuleBasedCollator getCharacterCollator(int collationType);
If the collation type is UCS_BASIC, then Collator object returned by the new api above will be null. If the collation type is TERRITORY_BASED, then Collator object returned will be the one based on the territory of the database.
This new api will be used in a method on DVF which will take format id and collation type and return a DVD based on those 2 values. That method on DVF will first consturct a DVD using just the format id. For character trype format ids, this means that the DVD will always be SQLChar/SQLVarchar/SQLLongvarchar/SQLClob. This is ok if we are dealing with collation type of UCS_BASIC. But if the collation type is TERRITORY_BASED, then we should construct a DVD of type CollatorSQLChar/CollatorSQLVarchar/CollatorSQLLongvarchar/CollatorSQLClob. In order to construct these collation sensitive DVDs, the method on DVF will call the new api on DVF (getCharacterCollator) and it will use the return Collator from getCharacterCollator to construct the right kind of character DVD.
> Make Locale available in DataValueFactory(DVF). This Locale object will be used to construct Collator object if the user has requested territory based collation.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2535
> URL: https://issues.apache.org/jira/browse/DERBY-2535
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2535_Return_Collator_api_On_DVD_v1_diff.txt, DERBY2535_Return_Collator_api_On_DVD_v1_stat.txt, DERBY2535_Set_Locale_On_DVF_v1_diff.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Uncomment_locale_setting_on_DVF_v1_diff.txt
>
>
> Add a new api on DVF which will make Locale object available to DVF. This new api on DVF will get called by the boot method of BasicDatabase after BasicDatabase has finished booting DVF. This Locale will be either the Locale obtained from the territory attribute supplied by the user on the JDBC url at database create time or if user didn't provide the territory attribute at database create time, then it will be set to the default JVM locale. This Locale object will be used by DVF to construct the Collator object if user has requested territory based collation.
> The new api will look like following
> void setLocale(Locale localeOfTheDatabase);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2535) Make Locale available in
DataValueFactory(DVF). This Locale object will be used to construct
Collator object if the user has requested territory based collation.
Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487842 ]
Mamta A. Satoor commented on DERBY-2535:
----------------------------------------
Army, thanks for the careful review about DVF creation. BasicDatabase is the first one to create DVF and then it sets the locale on the DVF. Later in it's boot code, BasicDatabase creates LanguageConnectionFactory which causes a call to GenericLanguageConnectionFactory.boot. When GenericLanguageConnectionFactory asks Monitor to get DVF, Monitor return the already created DVF which has the locale set on it. So, although we see Monitor code getting called twice for DVF, the 2nd time around we get the same instance that was created by the first call.
Thanks Army for your time in reviewing the code.
> Make Locale available in DataValueFactory(DVF). This Locale object will be used to construct Collator object if the user has requested territory based collation.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2535
> URL: https://issues.apache.org/jira/browse/DERBY-2535
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2535_Set_Locale_On_DVF_v1_diff.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Uncomment_locale_setting_on_DVF_v1_diff.txt
>
>
> Add a new api on DVF which will make Locale object available to DVF. This new api on DVF will get called by the boot method of BasicDatabase after BasicDatabase has finished booting DVF. This Locale will be either the Locale obtained from the territory attribute supplied by the user on the JDBC url at database create time or if user didn't provide the territory attribute at database create time, then it will be set to the default JVM locale. This Locale object will be used by DVF to construct the Collator object if user has requested territory based collation.
> The new api will look like following
> void setLocale(Locale localeOfTheDatabase);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2535) Make Locale available in
DataValueFactory(DVF). This Locale object will be used to construct
Collator object if the user has requested territory based collation.
Posted by "A B (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487808 ]
A B commented on DERBY-2535:
----------------------------
Thank you for the patch, Mamta. I took a quick look at it and I just have one question: with this patch we now call the new "setLocale()" method on the DataValueFactory that is created within the BasicDatabase.boot() method. That part looks good. My question arises from the fact that there are actually *two* places in the code where we create a DataValueFactory. You've changed the first one, but there is another call in:
sql/conn/GenericLanguageConnectionFactory.boot()
that looks identical to the one you've already changed. Does this second DataValueFactory need to have its locale set, as well? Or is it not required in this particular case?
I haven't looked into the code so maybe the "boot()" method in GenericLanguageConnectionFactory returns the same DVF that is created in BasicDatabase.boot()? If that's the case then I can see why we do not need to set locale a second time. But as I'm not familiar with this code, I thought I'd bring it up...
Also, I noticed that in the patch that you actually committed, the call to "setLocale()" is commented out (which is not the case in the patch that you posted). Was that an intentional "incremental development" decision since the feature is not fully implemented yet?
> Make Locale available in DataValueFactory(DVF). This Locale object will be used to construct Collator object if the user has requested territory based collation.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2535
> URL: https://issues.apache.org/jira/browse/DERBY-2535
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2535_Set_Locale_On_DVF_v1_diff.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt
>
>
> Add a new api on DVF which will make Locale object available to DVF. This new api on DVF will get called by the boot method of BasicDatabase after BasicDatabase has finished booting DVF. This Locale will be either the Locale obtained from the territory attribute supplied by the user on the JDBC url at database create time or if user didn't provide the territory attribute at database create time, then it will be set to the default JVM locale. This Locale object will be used by DVF to construct the Collator object if user has requested territory based collation.
> The new api will look like following
> void setLocale(Locale localeOfTheDatabase);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2535) Make Locale available in
DataValueFactory(DVF). This Locale object will be used to construct
Collator object if the user has requested territory based collation.
Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mamta A. Satoor updated DERBY-2535:
-----------------------------------
Attachment: DERBY2535_Return_Collator_api_On_DVD_v1_stat.txt
DERBY2535_Return_Collator_api_On_DVD_v1_diff.txt
Attaching patch DERBY2535_Return_Collator_api_On_DVD_v1_diff.txt which adds the api on DVD to return the Collator object depending on the collation type. The new api looks as follows
RuleBasedCollator getCharacterCollator(int collationType);
If the collation type is UCS_BASIC, then Collator object returned by the new api above will be null. If the collation type is TERRITORY_BASED, then Collator object returned will be the one based on the territory of the database.
This new api will be used in a method on DataValueFactory(DVF) which will take format id and collation type and return a DVD based on those 2 values. That method on DVF will first consturct a DVD using just the format id. For character trype format ids, this means that the DVD will always be SQLChar/SQLVarchar/SQLLongvarchar/SQLClob. This is ok if we are dealing with collation type of UCS_BASIC. But if the collation type is TERRITORY_BASED, then we shoould construct a DVD of type CollatorSQLChar/CollatorSQLVarchar/CollatorSQLLongvarchar/CollatorSQLClob. In order to construct these collation sensitive DVDs, the method on DVF will call the new api on DVD (getCharacterCollator) and it will use the return Collator from getCharacterCollator to construct the right kind of character DVD.
I will commit this patch in next few minutes. Any comments, please let me know.
> Make Locale available in DataValueFactory(DVF). This Locale object will be used to construct Collator object if the user has requested territory based collation.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2535
> URL: https://issues.apache.org/jira/browse/DERBY-2535
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2535_Return_Collator_api_On_DVD_v1_diff.txt, DERBY2535_Return_Collator_api_On_DVD_v1_stat.txt, DERBY2535_Set_Locale_On_DVF_v1_diff.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Uncomment_locale_setting_on_DVF_v1_diff.txt
>
>
> Add a new api on DVF which will make Locale object available to DVF. This new api on DVF will get called by the boot method of BasicDatabase after BasicDatabase has finished booting DVF. This Locale will be either the Locale obtained from the territory attribute supplied by the user on the JDBC url at database create time or if user didn't provide the territory attribute at database create time, then it will be set to the default JVM locale. This Locale object will be used by DVF to construct the Collator object if user has requested territory based collation.
> The new api will look like following
> void setLocale(Locale localeOfTheDatabase);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2535) Make Locale available in
DataValueFactory(DVF). This Locale object will be used to construct
Collator object if the user has requested territory based collation.
Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mamta A. Satoor updated DERBY-2535:
-----------------------------------
Comment: was deleted
> Make Locale available in DataValueFactory(DVF). This Locale object will be used to construct Collator object if the user has requested territory based collation.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2535
> URL: https://issues.apache.org/jira/browse/DERBY-2535
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2535_Return_Collator_api_On_DVD_v1_diff.txt, DERBY2535_Return_Collator_api_On_DVD_v1_stat.txt, DERBY2535_Set_Locale_On_DVF_v1_diff.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Uncomment_locale_setting_on_DVF_v1_diff.txt
>
>
> Add a new api on DVF which will make Locale object available to DVF. This new api on DVF will get called by the boot method of BasicDatabase after BasicDatabase has finished booting DVF. This Locale will be either the Locale obtained from the territory attribute supplied by the user on the JDBC url at database create time or if user didn't provide the territory attribute at database create time, then it will be set to the default JVM locale. This Locale object will be used by DVF to construct the Collator object if user has requested territory based collation.
> The new api will look like following
> void setLocale(Locale localeOfTheDatabase);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2535) Make Locale available in
DataValueFactory(DVF). This Locale object will be used to construct
Collator object if the user has requested territory based collation.
Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487873 ]
Mamta A. Satoor commented on DERBY-2535:
----------------------------------------
Committed a comment on GenericLanguageConnectionFactory as revision 527235.
> Make Locale available in DataValueFactory(DVF). This Locale object will be used to construct Collator object if the user has requested territory based collation.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2535
> URL: https://issues.apache.org/jira/browse/DERBY-2535
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2535_Set_Locale_On_DVF_v1_diff.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Uncomment_locale_setting_on_DVF_v1_diff.txt
>
>
> Add a new api on DVF which will make Locale object available to DVF. This new api on DVF will get called by the boot method of BasicDatabase after BasicDatabase has finished booting DVF. This Locale will be either the Locale obtained from the territory attribute supplied by the user on the JDBC url at database create time or if user didn't provide the territory attribute at database create time, then it will be set to the default JVM locale. This Locale object will be used by DVF to construct the Collator object if user has requested territory based collation.
> The new api will look like following
> void setLocale(Locale localeOfTheDatabase);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-2535) Make Locale available in
DataValueFactory(DVF). This Locale object will be used to construct
Collator object if the user has requested territory based collation.
Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mamta A. Satoor resolved DERBY-2535.
------------------------------------
Resolution: Fixed
> Make Locale available in DataValueFactory(DVF). This Locale object will be used to construct Collator object if the user has requested territory based collation.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2535
> URL: https://issues.apache.org/jira/browse/DERBY-2535
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2535_Return_Collator_api_On_DVD_v1_diff.txt, DERBY2535_Return_Collator_api_On_DVD_v1_stat.txt, DERBY2535_Set_Locale_On_DVF_v1_diff.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Uncomment_locale_setting_on_DVF_v1_diff.txt
>
>
> Add a new api on DVF which will make Locale object available to DVF. This new api on DVF will get called by the boot method of BasicDatabase after BasicDatabase has finished booting DVF. This Locale will be either the Locale obtained from the territory attribute supplied by the user on the JDBC url at database create time or if user didn't provide the territory attribute at database create time, then it will be set to the default JVM locale. This Locale object will be used by DVF to construct the Collator object if user has requested territory based collation.
> The new api will look like following
> void setLocale(Locale localeOfTheDatabase);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2535) Make Locale available in
DataValueFactory(DVF). This Locale object will be used to construct
Collator object if the user has requested territory based collation.
Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mamta A. Satoor updated DERBY-2535:
-----------------------------------
Attachment: DERBY2535_Set_Locale_On_DVF_v1_stat.txt
DERBY2535_Uncomment_locale_setting_on_DVF_v1_diff.txt
Army, thanks for the review. First let me answer the commenting of the call to "setLocale()". I was experimenting in my codeline after adding the patch to this Jira entry and that is when I commented out the call to setLocale. I will go ahead and uncomment it because I will need it for the next incremental step. The patch for the uncommenting change is DERBY2535_Uncomment_locale_setting_on_DVF_v1_diff.txt I will commit in next few minutes.
> Make Locale available in DataValueFactory(DVF). This Locale object will be used to construct Collator object if the user has requested territory based collation.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2535
> URL: https://issues.apache.org/jira/browse/DERBY-2535
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2535_Set_Locale_On_DVF_v1_diff.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Uncomment_locale_setting_on_DVF_v1_diff.txt
>
>
> Add a new api on DVF which will make Locale object available to DVF. This new api on DVF will get called by the boot method of BasicDatabase after BasicDatabase has finished booting DVF. This Locale will be either the Locale obtained from the territory attribute supplied by the user on the JDBC url at database create time or if user didn't provide the territory attribute at database create time, then it will be set to the default JVM locale. This Locale object will be used by DVF to construct the Collator object if user has requested territory based collation.
> The new api will look like following
> void setLocale(Locale localeOfTheDatabase);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2535) Make Locale available in
DataValueFactory(DVF). This Locale object will be used to construct
Collator object if the user has requested territory based collation.
Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487825 ]
Mamta A. Satoor commented on DERBY-2535:
----------------------------------------
Committed patch DERBY2535_Uncomment_locale_setting_on_DVF_v1_diff.txt using revision 527199.
> Make Locale available in DataValueFactory(DVF). This Locale object will be used to construct Collator object if the user has requested territory based collation.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2535
> URL: https://issues.apache.org/jira/browse/DERBY-2535
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2535_Set_Locale_On_DVF_v1_diff.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Uncomment_locale_setting_on_DVF_v1_diff.txt
>
>
> Add a new api on DVF which will make Locale object available to DVF. This new api on DVF will get called by the boot method of BasicDatabase after BasicDatabase has finished booting DVF. This Locale will be either the Locale obtained from the territory attribute supplied by the user on the JDBC url at database create time or if user didn't provide the territory attribute at database create time, then it will be set to the default JVM locale. This Locale object will be used by DVF to construct the Collator object if user has requested territory based collation.
> The new api will look like following
> void setLocale(Locale localeOfTheDatabase);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-2535) Make Locale available in
DataValueFactory(DVF). This Locale object will be used to construct
Collator object if the user has requested territory based collation.
Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mamta A. Satoor closed DERBY-2535.
----------------------------------
> Make Locale available in DataValueFactory(DVF). This Locale object will be used to construct Collator object if the user has requested territory based collation.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2535
> URL: https://issues.apache.org/jira/browse/DERBY-2535
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2535_Return_Collator_api_On_DVD_v1_diff.txt, DERBY2535_Return_Collator_api_On_DVD_v1_stat.txt, DERBY2535_Set_Locale_On_DVF_v1_diff.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Set_Locale_On_DVF_v1_stat.txt, DERBY2535_Uncomment_locale_setting_on_DVF_v1_diff.txt
>
>
> Add a new api on DVF which will make Locale object available to DVF. This new api on DVF will get called by the boot method of BasicDatabase after BasicDatabase has finished booting DVF. This Locale will be either the Locale obtained from the territory attribute supplied by the user on the JDBC url at database create time or if user didn't provide the territory attribute at database create time, then it will be set to the default JVM locale. This Locale object will be used by DVF to construct the Collator object if user has requested territory based collation.
> The new api will look like following
> void setLocale(Locale localeOfTheDatabase);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.