You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@santuario.apache.org by bu...@apache.org on 2010/06/16 21:33:06 UTC

DO NOT REPLY [Bug 49450] New: KeyStoreResolver always exhausted after first use

https://issues.apache.org/bugzilla/show_bug.cgi?id=49450

           Summary: KeyStoreResolver always exhausted after first use
           Product: Security
           Version: unspecified
          Platform: PC
        OS/Version: Windows NT
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Encryption
        AssignedTo: security-dev@xml.apache.org
        ReportedBy: Clement_Pellerin@ibi.com
        Depends on: 49447


The KeyStoreResolver creates an iterator once and always returns the same
iterator afterwards. After the iterator is traversed once, it will always
appear empty. Even if the implementation would be changed to reset the alias
enumeration to the beginning, the single iterator instance approach will never
be thread-safe.

To reproduce, run the KeyStoreResolverTest in attachment.

The solution is to return a new iterator instance each time.
This patch is built on top of the patch found in Bug 49447.
This patch also fixes a bug with the NoSuchElementException that was introduced
in the patch attached to 49447.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 49450] KeyStoreResolver always exhausted after first use

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49450

Bug 49450 depends on bug 49447, which changed state.

Bug 49447 Summary: KeyStoreResolver iterator returns null for symmetric keys
https://issues.apache.org/bugzilla/show_bug.cgi?id=49447

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 49450] KeyStoreResolver always exhausted after first use

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49450

--- Comment #1 from Clement Pellerin <Cl...@ibi.com> 2010-06-16 15:35:20 EDT ---
Created an attachment (id=25600)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25600)
proposed source code patch with junit

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 49450] KeyStoreResolver always exhausted after first use

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49450

coheigea <co...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from coheigea <co...@apache.org> 2010-06-17 09:27:38 EDT ---

Patch applied, thanks. I modified it slightly so that the KeyStoreResolver
checks the KeyStore in the constructor, and throws a StorageResolverException
if there is a problem. This is for backwards compatiblity reasons.

Colm.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.