[jira] Commented: (TEXEN-17) Default properties of Generator are processed differently than the propertie file(s) given in the Ant-task

["Nathan Bubna (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEXEN-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851457#action_12851457 ] 

Nathan Bubna commented on TEXEN-17:
-----------------------------------

Fedor, thanks for the patch, though it is hard to see what the actual changes are amidst all of the style changes.   Would you be able to resubmit the patch without all the extraneous changes?

> Default properties of Generator are processed differently than the propertie file(s) given in the Ant-task
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: TEXEN-17
>                 URL: https://issues.apache.org/jira/browse/TEXEN-17
>             Project: Texen
>          Issue Type: Bug
>    Affects Versions: 1.1
>            Reporter: Fedor Jutte
>             Fix For: 1.1
>
>         Attachments: texen17-patch.txt
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The TexenTask uses TexenUtils.populateContext() to populate the context.
> Instead of reusing TexenUtils.populateContext(), Generator.fillContextProperties() uses it's own, slightly different, algorithm to fill the context with it's default properties.
> Difference:
> TexenUtils.populateContext() provides additional support for entries like "license.file.contents = license.txt", but Generator.fillContextProperties() doesn't.
> Generator.fillContextProperties() provides additional supports for entries like "context.objects.strings=org.apache.velocity.util.StringUtils", but TexenUtils.populateContext() doesn't.
> SOLUTION:
> Instead of giving Generator.fillContextProperties() it's own algorithm, it should use TexenUtils.populateContext(). And the additional support for objects in Generator.fillContextProperties() should be added to TexenUtils.populateContext().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org