[jira] [Commented] (WICKET-6325) AbstractTree#updateBranch() and #updateNode() make AjaxRequestTarget mandatory

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-6325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880539#comment-15880539 ] 

ASF subversion and git services commented on WICKET-6325:
---------------------------------------------------------

Commit 3bb858f96b2754f3386055f6b21e30c56d79b9be in wicket's branch refs/heads/master from [~svenmeier]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=3bb858f ]

WICKET-6325 ART is a mandatory parameter now


> AbstractTree#updateBranch() and #updateNode() make AjaxRequestTarget mandatory
> ------------------------------------------------------------------------------
>
>                 Key: WICKET-6325
>                 URL: https://issues.apache.org/jira/browse/WICKET-6325
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 8.0.0-M3
>            Reporter: Sven Meier
>            Assignee: Sven Meier
>            Priority: Minor
>
> With the new Optional<AjaxRequestTarget> spreading over Wickets code base, AbstractTree#updateBranch() and #updateNode() were changed (by me) to get an optional ART.
> Further examination shows, that this was a wrong decision:
> - most Java experts argue against optional method parameters
> - there are cases now where an existing ART must be wrapped in an optional just to pass it into the methods.
> The former solution to check the parameter against null isn't feasible now either, since you have to use optional#orElse(null) if you happen to have an Optional<ART> only.
> Thus it is better to just make the ART parameter mandatory.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)