You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/30 12:51:20 UTC

[GitHub] [flink] azagrebin commented on a change in pull request #9250: [FLINK-13371][coordination] Prevent leaks of blocking partitions

azagrebin commented on a change in pull request #9250: [FLINK-13371][coordination] Prevent leaks of blocking partitions 
URL: https://github.com/apache/flink/pull/9250#discussion_r308694904
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
 ##########
 @@ -1311,16 +1312,47 @@ private void startTrackingPartitions(final ResourceID taskExecutorId, final Coll
 		}
 	}
 
+	void stopTrackingPartitions() {
+		stopTrackingAndReleasePartitions(false);
+	}
+
 	void stopTrackingAndReleasePartitions() {
 		LOG.info("Discarding the results produced by task execution {}.", attemptId);
+		stopTrackingAndReleasePartitions(true);
+	}
+
+	private void stopTrackingAndReleasePartitions(boolean release) {
 
 Review comment:
   `stopTrackingAndOptionallyReleasePartitions`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services