[GitHub] [arrow-ballista] r4ntix commented on a diff in pull request #805: Add support for GCS data sources

["r4ntix (via GitHub)" <gi...@apache.org>]

r4ntix commented on code in PR #805:
URL: https://github.com/apache/arrow-ballista/pull/805#discussion_r1219331222


##########
ballista/core/src/utils.rs:
##########
@@ -148,6 +150,20 @@ impl BallistaObjectStoreRegistry {
             }
         }
 
+        #[cfg(feature = "gcs")]
+        {
+            if url.to_string().starts_with("gs://") {

Review Comment:
   Thanks @haoxins 👏
   The current google cloud storage has 2 types of url schema: "gs://" or "gcs://". So here we also need to add support for "gcs://".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org