You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by wuchong <gi...@git.apache.org> on 2017/08/14 08:48:39 UTC

[GitHub] flink pull request #4538: [FLINK-7441] [table] Double quote string literals ...

GitHub user wuchong opened a pull request:

    https://github.com/apache/flink/pull/4538

    [FLINK-7441] [table] Double quote string literals is not supported in Table API and SQL

    ## What is the purpose of the change
    
    Code generation doesn't handle double quote string literals and some control characters which leads to compile error.
    
    ## Brief change log
    
    - add string escape to `CodeGenerator#visitLiteral`
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
    - Added test `UserDefinedScalarFunctionTest#testDoubleQuoteParameters ` that validate double quotes can be handled correctly.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? na
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wuchong/flink double-quote

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4538.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4538
    
----
commit fdec04d4fe9257b952bf2a150ab1cae9481e5f32
Author: Jark Wu <ja...@apache.org>
Date:   2017-08-14T08:44:16Z

    [FLINK-7441] [table] Double quote string literals is not supported in Table API and SQL

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4538: [FLINK-7441] [table] Double quote string literals ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4538


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4538: [FLINK-7441] [table] Double quote string literals is not ...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4538
  
    @twalthr @wuchong Please make sure that the commit messages describes what was changed, and not the state before the change. We now have a commit that adds support for quoted strings, with the commit message saying that this isn't supported.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4538: [FLINK-7441] [table] Double quote string literals is not ...

Posted by wuchong <gi...@git.apache.org>.

Github user wuchong commented on the issue:

    https://github.com/apache/flink/pull/4538
  
    Thanks for the reminding @zentol . I will pay attention to the commit message in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4538: [FLINK-7441] [table] Double quote string literals is not ...

Posted by twalthr <gi...@git.apache.org>.

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/4538
  
    Thanks for the PR @wuchong. Very important fix. I will merge it now...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---