You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ilya Berezhniuk (JIRA)" <ji...@apache.org> on 2006/09/13 17:00:22 UTC
[jira] Created: (HARMONY-1457) [DRLVM] Patch provided for APR
threads for Windows and VM code is adopted
[DRLVM] Patch provided for APR threads for Windows and VM code is adopted
-------------------------------------------------------------------------
Key: HARMONY-1457
URL: http://issues.apache.org/jira/browse/HARMONY-1457
Project: Harmony
Issue Type: Bug
Components: DRLVM
Environment: Windows
Reporter: Ilya Berezhniuk
There was a bug in APR threads implementation for Windows.
apr_os_thread_get and apr_os_thread_put functions perform implicit cast from HANDLE* to HANDLE and visa versa.
It was possible because HANDLE is void*, but it resulted in invalid OS handle.
It prevented apr_thread_yield_other and apr_thread_cancel functions to work correctly.
Patch provided for APR threadproc/win32/thread.c file. PORT sources for Windows were adopted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1457) [DRLVM] Patch provided for APR
threads for Windows and VM code is adopted
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1457?page=comments#action_12437168 ]
Gregory Shimansky commented on HARMONY-1457:
--------------------------------------------
Hmm I tried to reproduce the problem you've encountered... I cleaned everything, did build.bat update (maybe you didn't do it?)and built VM. The c-unit tests worked just fine to me. The smoke gc.LOS test still hangs as usual.
Ilya in his patch added a new file (albeilt with DOS line endings) to directory build/patches. These patches are copied to the corresponding lib directories when VM is built to cover the bugs in APR (and other?) library. So after applying this patch it is critical to do build.bat update. The same can be said about HARMONY-1519.
> [DRLVM] Patch provided for APR threads for Windows and VM code is adopted
> -------------------------------------------------------------------------
>
> Key: HARMONY-1457
> URL: http://issues.apache.org/jira/browse/HARMONY-1457
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows
> Reporter: Ilya Berezhniuk
> Assigned To: Geir Magnusson Jr
> Attachments: apr-threads.patch
>
>
> There was a bug in APR threads implementation for Windows.
> apr_os_thread_get and apr_os_thread_put functions perform implicit cast from HANDLE* to HANDLE and visa versa.
> It was possible because HANDLE is void*, but it resulted in invalid OS handle.
> It prevented apr_thread_yield_other and apr_thread_cancel functions to work correctly.
> Patch provided for APR threadproc/win32/thread.c file. PORT sources for Windows were adopted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1457) [DRLVM] Patch provided for APR
threads for Windows and VM code is adopted
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1457?page=comments#action_12437731 ]
Geir Magnusson Jr commented on HARMONY-1457:
--------------------------------------------
Note that I only half committed this - other half in r449906
> [DRLVM] Patch provided for APR threads for Windows and VM code is adopted
> -------------------------------------------------------------------------
>
> Key: HARMONY-1457
> URL: http://issues.apache.org/jira/browse/HARMONY-1457
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows
> Reporter: Ilya Berezhniuk
> Assigned To: Geir Magnusson Jr
> Attachments: apr-threads.patch
>
>
> There was a bug in APR threads implementation for Windows.
> apr_os_thread_get and apr_os_thread_put functions perform implicit cast from HANDLE* to HANDLE and visa versa.
> It was possible because HANDLE is void*, but it resulted in invalid OS handle.
> It prevented apr_thread_yield_other and apr_thread_cancel functions to work correctly.
> Patch provided for APR threadproc/win32/thread.c file. PORT sources for Windows were adopted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1457) [DRLVM] Patch provided for APR
threads for Windows and VM code is adopted
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1457?page=comments#action_12437073 ]
Geir Magnusson Jr commented on HARMONY-1457:
--------------------------------------------
Sorry - after a clean build and clean test run, applying this patch results in the first thread test failing in the c-unit tests :
[echo] ## Executing C unit test: test_java_attrs
[exec] Result: -1073741819
[echo] INFO: TEST test_jthread_get_priority start
[echo] ## TEST FAILED
Either the test is broken or the patch is.
> [DRLVM] Patch provided for APR threads for Windows and VM code is adopted
> -------------------------------------------------------------------------
>
> Key: HARMONY-1457
> URL: http://issues.apache.org/jira/browse/HARMONY-1457
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows
> Reporter: Ilya Berezhniuk
> Assigned To: Geir Magnusson Jr
> Attachments: apr-threads.patch
>
>
> There was a bug in APR threads implementation for Windows.
> apr_os_thread_get and apr_os_thread_put functions perform implicit cast from HANDLE* to HANDLE and visa versa.
> It was possible because HANDLE is void*, but it resulted in invalid OS handle.
> It prevented apr_thread_yield_other and apr_thread_cancel functions to work correctly.
> Patch provided for APR threadproc/win32/thread.c file. PORT sources for Windows were adopted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1457) [DRLVM] Patch provided for APR
threads for Windows and VM code is adopted
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1457?page=all ]
weldon washburn closed HARMONY-1457.
------------------------------------
Resolution: Fixed
closed!
> [DRLVM] Patch provided for APR threads for Windows and VM code is adopted
> -------------------------------------------------------------------------
>
> Key: HARMONY-1457
> URL: http://issues.apache.org/jira/browse/HARMONY-1457
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows
> Reporter: Ilya Berezhniuk
> Assigned To: weldon washburn
> Attachments: apr-threads.patch
>
>
> There was a bug in APR threads implementation for Windows.
> apr_os_thread_get and apr_os_thread_put functions perform implicit cast from HANDLE* to HANDLE and visa versa.
> It was possible because HANDLE is void*, but it resulted in invalid OS handle.
> It prevented apr_thread_yield_other and apr_thread_cancel functions to work correctly.
> Patch provided for APR threadproc/win32/thread.c file. PORT sources for Windows were adopted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1457) [DRLVM] Patch provided for APR
threads for Windows and VM code is adopted
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1457?page=all ]
Geir Magnusson Jr resolved HARMONY-1457.
----------------------------------------
Resolution: Fixed
r449399
winxp - c-unit and some smoke
> [DRLVM] Patch provided for APR threads for Windows and VM code is adopted
> -------------------------------------------------------------------------
>
> Key: HARMONY-1457
> URL: http://issues.apache.org/jira/browse/HARMONY-1457
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows
> Reporter: Ilya Berezhniuk
> Assigned To: Geir Magnusson Jr
> Attachments: apr-threads.patch
>
>
> There was a bug in APR threads implementation for Windows.
> apr_os_thread_get and apr_os_thread_put functions perform implicit cast from HANDLE* to HANDLE and visa versa.
> It was possible because HANDLE is void*, but it resulted in invalid OS handle.
> It prevented apr_thread_yield_other and apr_thread_cancel functions to work correctly.
> Patch provided for APR threadproc/win32/thread.c file. PORT sources for Windows were adopted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (HARMONY-1457) [DRLVM] Patch provided for APR
threads for Windows and VM code is adopted
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1457?page=all ]
weldon washburn reopened HARMONY-1457:
--------------------------------------
only 1/2 of the patch was properly applied. Now adding win32 thread.c
> [DRLVM] Patch provided for APR threads for Windows and VM code is adopted
> -------------------------------------------------------------------------
>
> Key: HARMONY-1457
> URL: http://issues.apache.org/jira/browse/HARMONY-1457
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows
> Reporter: Ilya Berezhniuk
> Assigned To: Geir Magnusson Jr
> Attachments: apr-threads.patch
>
>
> There was a bug in APR threads implementation for Windows.
> apr_os_thread_get and apr_os_thread_put functions perform implicit cast from HANDLE* to HANDLE and visa versa.
> It was possible because HANDLE is void*, but it resulted in invalid OS handle.
> It prevented apr_thread_yield_other and apr_thread_cancel functions to work correctly.
> Patch provided for APR threadproc/win32/thread.c file. PORT sources for Windows were adopted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1457) [DRLVM] Patch provided for APR
threads for Windows and VM code is adopted
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1457?page=comments#action_12435350 ]
weldon washburn commented on HARMONY-1457:
------------------------------------------
I'm OK with committing this code. This is straight forward OS API wrapper code. (APR on top of Win). It looks like APR is fairly close to POSIX API and thus no need for APR on top of Linux. Is this correct?
> [DRLVM] Patch provided for APR threads for Windows and VM code is adopted
> -------------------------------------------------------------------------
>
> Key: HARMONY-1457
> URL: http://issues.apache.org/jira/browse/HARMONY-1457
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows
> Reporter: Ilya Berezhniuk
> Attachments: apr-threads.patch
>
>
> There was a bug in APR threads implementation for Windows.
> apr_os_thread_get and apr_os_thread_put functions perform implicit cast from HANDLE* to HANDLE and visa versa.
> It was possible because HANDLE is void*, but it resulted in invalid OS handle.
> It prevented apr_thread_yield_other and apr_thread_cancel functions to work correctly.
> Patch provided for APR threadproc/win32/thread.c file. PORT sources for Windows were adopted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1457) [DRLVM] Patch provided for APR
threads for Windows and VM code is adopted
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1457?page=all ]
Ilya Berezhniuk updated HARMONY-1457:
-------------------------------------
Attachment: apr-threads.patch
> [DRLVM] Patch provided for APR threads for Windows and VM code is adopted
> -------------------------------------------------------------------------
>
> Key: HARMONY-1457
> URL: http://issues.apache.org/jira/browse/HARMONY-1457
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows
> Reporter: Ilya Berezhniuk
> Attachments: apr-threads.patch
>
>
> There was a bug in APR threads implementation for Windows.
> apr_os_thread_get and apr_os_thread_put functions perform implicit cast from HANDLE* to HANDLE and visa versa.
> It was possible because HANDLE is void*, but it resulted in invalid OS handle.
> It prevented apr_thread_yield_other and apr_thread_cancel functions to work correctly.
> Patch provided for APR threadproc/win32/thread.c file. PORT sources for Windows were adopted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1457) [DRLVM] Patch provided for APR
threads for Windows and VM code is adopted
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1457?page=all ]
Geir Magnusson Jr closed HARMONY-1457.
--------------------------------------
> [DRLVM] Patch provided for APR threads for Windows and VM code is adopted
> -------------------------------------------------------------------------
>
> Key: HARMONY-1457
> URL: http://issues.apache.org/jira/browse/HARMONY-1457
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows
> Reporter: Ilya Berezhniuk
> Assigned To: Geir Magnusson Jr
> Attachments: apr-threads.patch
>
>
> There was a bug in APR threads implementation for Windows.
> apr_os_thread_get and apr_os_thread_put functions perform implicit cast from HANDLE* to HANDLE and visa versa.
> It was possible because HANDLE is void*, but it resulted in invalid OS handle.
> It prevented apr_thread_yield_other and apr_thread_cancel functions to work correctly.
> Patch provided for APR threadproc/win32/thread.c file. PORT sources for Windows were adopted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1457) [DRLVM] Patch provided for APR
threads for Windows and VM code is adopted
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1457?page=all ]
Geir Magnusson Jr reassigned HARMONY-1457:
------------------------------------------
Assignee: Geir Magnusson Jr
> [DRLVM] Patch provided for APR threads for Windows and VM code is adopted
> -------------------------------------------------------------------------
>
> Key: HARMONY-1457
> URL: http://issues.apache.org/jira/browse/HARMONY-1457
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows
> Reporter: Ilya Berezhniuk
> Assigned To: Geir Magnusson Jr
> Attachments: apr-threads.patch
>
>
> There was a bug in APR threads implementation for Windows.
> apr_os_thread_get and apr_os_thread_put functions perform implicit cast from HANDLE* to HANDLE and visa versa.
> It was possible because HANDLE is void*, but it resulted in invalid OS handle.
> It prevented apr_thread_yield_other and apr_thread_cancel functions to work correctly.
> Patch provided for APR threadproc/win32/thread.c file. PORT sources for Windows were adopted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1457) [DRLVM] Patch provided for APR
threads for Windows and VM code is adopted
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1457?page=all ]
weldon washburn reassigned HARMONY-1457:
----------------------------------------
Assignee: weldon washburn (was: Geir Magnusson Jr)
> [DRLVM] Patch provided for APR threads for Windows and VM code is adopted
> -------------------------------------------------------------------------
>
> Key: HARMONY-1457
> URL: http://issues.apache.org/jira/browse/HARMONY-1457
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows
> Reporter: Ilya Berezhniuk
> Assigned To: weldon washburn
> Attachments: apr-threads.patch
>
>
> There was a bug in APR threads implementation for Windows.
> apr_os_thread_get and apr_os_thread_put functions perform implicit cast from HANDLE* to HANDLE and visa versa.
> It was possible because HANDLE is void*, but it resulted in invalid OS handle.
> It prevented apr_thread_yield_other and apr_thread_cancel functions to work correctly.
> Patch provided for APR threadproc/win32/thread.c file. PORT sources for Windows were adopted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1457) [DRLVM] Patch provided for APR
threads for Windows and VM code is adopted
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1457?page=comments#action_12435389 ]
Geir Magnusson Jr commented on HARMONY-1457:
--------------------------------------------
Waiting for HARMONY-1421 to be fixed
> [DRLVM] Patch provided for APR threads for Windows and VM code is adopted
> -------------------------------------------------------------------------
>
> Key: HARMONY-1457
> URL: http://issues.apache.org/jira/browse/HARMONY-1457
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows
> Reporter: Ilya Berezhniuk
> Attachments: apr-threads.patch
>
>
> There was a bug in APR threads implementation for Windows.
> apr_os_thread_get and apr_os_thread_put functions perform implicit cast from HANDLE* to HANDLE and visa versa.
> It was possible because HANDLE is void*, but it resulted in invalid OS handle.
> It prevented apr_thread_yield_other and apr_thread_cancel functions to work correctly.
> Patch provided for APR threadproc/win32/thread.c file. PORT sources for Windows were adopted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1457) [DRLVM] Patch provided for APR
threads for Windows and VM code is adopted
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1457?page=comments#action_12439659 ]
Geir Magnusson Jr commented on HARMONY-1457:
--------------------------------------------
I believe we can close this now? I did commit the other half
> [DRLVM] Patch provided for APR threads for Windows and VM code is adopted
> -------------------------------------------------------------------------
>
> Key: HARMONY-1457
> URL: http://issues.apache.org/jira/browse/HARMONY-1457
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows
> Reporter: Ilya Berezhniuk
> Assigned To: weldon washburn
> Attachments: apr-threads.patch
>
>
> There was a bug in APR threads implementation for Windows.
> apr_os_thread_get and apr_os_thread_put functions perform implicit cast from HANDLE* to HANDLE and visa versa.
> It was possible because HANDLE is void*, but it resulted in invalid OS handle.
> It prevented apr_thread_yield_other and apr_thread_cancel functions to work correctly.
> Patch provided for APR threadproc/win32/thread.c file. PORT sources for Windows were adopted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1457) [DRLVM] Patch provided for APR
threads for Windows and VM code is adopted
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1457?page=comments#action_12437205 ]
Geir Magnusson Jr commented on HARMONY-1457:
--------------------------------------------
yep, that was it. Wasn't obvious to me, but I guess if the patching is done there, it makes sense. Test passing, hanging on gc.LOS
> [DRLVM] Patch provided for APR threads for Windows and VM code is adopted
> -------------------------------------------------------------------------
>
> Key: HARMONY-1457
> URL: http://issues.apache.org/jira/browse/HARMONY-1457
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows
> Reporter: Ilya Berezhniuk
> Assigned To: Geir Magnusson Jr
> Attachments: apr-threads.patch
>
>
> There was a bug in APR threads implementation for Windows.
> apr_os_thread_get and apr_os_thread_put functions perform implicit cast from HANDLE* to HANDLE and visa versa.
> It was possible because HANDLE is void*, but it resulted in invalid OS handle.
> It prevented apr_thread_yield_other and apr_thread_cancel functions to work correctly.
> Patch provided for APR threadproc/win32/thread.c file. PORT sources for Windows were adopted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1457) [DRLVM] Patch provided for APR
threads for Windows and VM code is adopted
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1457?page=comments#action_12442245 ]
weldon washburn commented on HARMONY-1457:
------------------------------------------
[[ Old comment, sent by email on Tue, 3 Oct 2006 20:48:09 -0700 ]]
done.
--
Weldon Washburn
Intel Middleware Products Division
> [DRLVM] Patch provided for APR threads for Windows and VM code is adopted
> -------------------------------------------------------------------------
>
> Key: HARMONY-1457
> URL: http://issues.apache.org/jira/browse/HARMONY-1457
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Windows
> Reporter: Ilya Berezhniuk
> Assigned To: weldon washburn
> Attachments: apr-threads.patch
>
>
> There was a bug in APR threads implementation for Windows.
> apr_os_thread_get and apr_os_thread_put functions perform implicit cast from HANDLE* to HANDLE and visa versa.
> It was possible because HANDLE is void*, but it resulted in invalid OS handle.
> It prevented apr_thread_yield_other and apr_thread_cancel functions to work correctly.
> Patch provided for APR threadproc/win32/thread.c file. PORT sources for Windows were adopted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira