You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/12/22 19:26:45 UTC

[GitHub] [hudi] pratyakshsharma commented on a change in pull request #2768: [HUDI-485]: corrected the check for incremental sql

pratyakshsharma commented on a change in pull request #2768:
URL: https://github.com/apache/hudi/pull/2768#discussion_r774117277



##########
File path: hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/testutils/HiveTestUtil.java
##########
@@ -126,6 +126,16 @@ public static void setUp() throws IOException, InterruptedException, HiveExcepti
     clear();
   }
 
+  public static void clearIncrementalPullSetup(String path1, String path2) throws IOException, HiveException, MetaException {

Review comment:
       path2 can be null. But yeah we can remove exists check since that is already covered in delete() method. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org