You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by ccorcos <gi...@git.apache.org> on 2017/06/15 01:54:10 UTC
[GitHub] cordova-plugin-wkwebview-engine pull request #38: Dynamic Swipe Preference
GitHub user ccorcos opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38
Dynamic Swipe Preference
This PR lets you dynamically change whether or not you can swipe navigation using `window.WkWebView.allowsBackForwardNavigationGestures(boolean)`
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ccorcos/cordova-plugin-wkwebview-engine dynamic-swipe-pref
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit 1109a1ace113579e76ad2384f966d8442ce14b4f
Author: Chet Corcos <cc...@gmail.com>
Date: 2017-06-15T01:04:14Z
Dynamically set allowsBackForwardNavigationGestures
commit 0b6b29f9dee9cf326313639bf197c09c19c9dd18
Author: Chet Corcos <cc...@gmail.com>
Date: 2017-06-15T01:35:16Z
Move code into proper @implementation
commit cf1cb7b82516d4103f9913868183e829eab3b912
Author: Chet Corcos <cc...@gmail.com>
Date: 2017-06-15T01:46:51Z
Separate window.WkWebView js module into another file
commit 410b6cf4adc544e9d62c59e1fe5875d57bc3b2cc
Author: Chet Corcos <cc...@gmail.com>
Date: 2017-06-15T01:50:55Z
Readme
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference
Posted by ccorcos <gi...@git.apache.org>.
Github user ccorcos commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38
@shazron does this PR have any chance of making it in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request #38: Dynamic Swipe Preference
Posted by ccorcos <gi...@git.apache.org>.
Github user ccorcos closed the pull request at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38
@ccorcos seems to be really flaky these past few days. Even the status graph has given up: http://status.apache.org/ I eventually could get it to load
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference
Posted by larssn <gi...@git.apache.org>.
Github user larssn commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38
We've been ccorcos' branch. We needed the ability to open the keyboard on `element.focus()`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference
Posted by ccorcos <gi...@git.apache.org>.
Github user ccorcos commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38
@shazron is JIRA broken? My browser says failed to connect:
iled to connect to issues.apache.org port 443: Connection refused
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference
Posted by ccorcos <gi...@git.apache.org>.
Github user ccorcos commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38
lol. would you mind making a ticket for this? I can't seem to get it to load!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference
Posted by ccorcos <gi...@git.apache.org>.
Github user ccorcos commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38
Hmm. Is JIRA down?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference
Posted by ccorcos <gi...@git.apache.org>.
Github user ccorcos commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38
@shazron please check out my new PR https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference
Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38
Cordova CI Build has completed successfully.
**Commit** - [Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38/commits/410b6cf4adc544e9d62c59e1fe5875d57bc3b2cc)
**Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-wkwebview-engine-pr/30/)
2 tests run, 0 skipped, 0 failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38
Two issues:
1. The checklist for PRs was not adhered to
2. This fails CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org