You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/10/17 09:13:09 UTC

[GitHub] [pulsar] PierreZ opened a new pull request #5406: [Doc] Add *authenticateMetricsEndpoint* option in administration-prox…

PierreZ opened a new pull request #5406: [Doc] Add *authenticateMetricsEndpoint* option in administration-prox…
URL: https://github.com/apache/pulsar/pull/5406
 
 
   Hi!
   
   I found a missing parameter on the documentation of the Pulsar-Proxy.
   
   ### Motivation
   
   The parameter `authenticateMetricsEndpoint` was explained in the [Pulsar Configuration guide](https://pulsar.apache.org/docs/en/next/reference-configuration/#pulsar-proxy) but not on the [Pulsar-Proxy dedicated page](https://pulsar.apache.org/docs/en/next/administration-proxy/). 
   
   ### Modifications
   
   I added the missing parameter in the dedicated page, as it was the only missing parameter based on the main [Pulsar Configuration guide](https://pulsar.apache.org/docs/en/next/reference-configuration/#pulsar-proxy).
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   
   Have a nice day :sun_with_face: 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services