You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "ianmcook (via GitHub)" <gi...@apache.org> on 2025/08/04 16:03:00 UTC
[I] Alias `Record` to `RecordBatch` and soft-deprecate `Record` [arrow-go]
ianmcook opened a new issue, #457:
URL: https://github.com/apache/arrow-go/issues/457
### Describe the enhancement requested
The name `Record` is a semantic crime. We should try to make it gradually fade away.
### Component(s)
Documentation, Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Alias `Record` to `RecordBatch` and soft-deprecate `Record` [arrow-go]
Posted by "derekperkins (via GitHub)" <gi...@apache.org>.
derekperkins commented on issue #457:
URL: https://github.com/apache/arrow-go/issues/457#issuecomment-3268460929
FWIW, v18.4.1 introduced a breaking change for anyone implementing the `array.RecordReader` interface, which probably shouldn't have happened in a patch release.
- https://github.com/marcboeker/go-duckdb/issues/524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Alias `Record` to `RecordBatch` and soft-deprecate `Record` [arrow-go]
Posted by "Mandukhai-Alimaa (via GitHub)" <gi...@apache.org>.
Mandukhai-Alimaa commented on issue #457:
URL: https://github.com/apache/arrow-go/issues/457#issuecomment-3288669101
Hello, I read your comment. I apologize for the inconvenience this caused. We can’t revert this change because the number of people impacted was very small, and most have already addressed it by adding the new method to their interface. In fact, as @zeroshade mentioned above, we’ve also submitted PRs to help affected consumers as well. Reverting now would break things again for those users, so unfortunately that’s not a viable option.
The good news is that the fix is straightforward. It just requires adding the new method to your interface implementation. If you’d like, I’d be happy to submit a PR to help with the upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Alias `Record` to `RecordBatch` and soft-deprecate `Record` [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade closed issue #457: Alias `Record` to `RecordBatch` and soft-deprecate `Record`
URL: https://github.com/apache/arrow-go/issues/457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Alias `Record` to `RecordBatch` and soft-deprecate `Record` [arrow-go]
Posted by "prochac (via GitHub)" <gi...@apache.org>.
prochac commented on issue #457:
URL: https://github.com/apache/arrow-go/issues/457#issuecomment-3288867608
I have no personal experience with this tool, but possibly it could prevent the next breaking change in a patch version.
Ofc, it can't detect logic breaking changes, but these users facing API changes should be easily detected.
https://pkg.go.dev/golang.org/x/exp/cmd/gorelease
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Alias `Record` to `RecordBatch` and soft-deprecate `Record` [arrow-go]
Posted by "derekperkins (via GitHub)" <gi...@apache.org>.
derekperkins commented on issue #457:
URL: https://github.com/apache/arrow-go/issues/457#issuecomment-3268522390
Thanks for the response. I submitted a PR for that, it should be this simple, right?
https://github.com/marcboeker/go-duckdb/pull/525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Alias `Record` to `RecordBatch` and soft-deprecate `Record` [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on issue #457:
URL: https://github.com/apache/arrow-go/issues/457#issuecomment-3268524863
Yup! The cause of the break was just the addition of the `RecordBatch` method, so it's exactly as simple as your PR there is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Alias `Record` to `RecordBatch` and soft-deprecate `Record` [arrow-go]
Posted by "Mandukhai-Alimaa (via GitHub)" <gi...@apache.org>.
Mandukhai-Alimaa commented on issue #457:
URL: https://github.com/apache/arrow-go/issues/457#issuecomment-3151479373
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Alias `Record` to `RecordBatch` and soft-deprecate `Record` [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on issue #457:
URL: https://github.com/apache/arrow-go/issues/457#issuecomment-3268481425
Yea, we discovered that shortly after the release. Since the Apache rules require at least 3 days voting for a release, we ended up deciding that it was safest to include a note in the release notes (https://arrow.apache.org/blog/2025/09/04/arrow-go-18.4.1/) since we didn't want people to upgrade, discover and fix it, and then have us break them again and only a very small number of consumers would be affected by this (only if you're defining your own concrete implementation of RecordReader). It was definitely unintentional.
I did go around trying to find consumers that were affected and submitting some PRs to add the `RecordBatch` method to help the upgrades. My apologies for missing `go-duckdb`.
You're correct this shouldn't have happened in a patch release. If this change was something that would affect a larger number of consumers (very few actually define their own concrete RecordReader implementations) we would have responded differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Alias `Record` to `RecordBatch` and soft-deprecate `Record` [arrow-go]
Posted by "Mandukhai-Alimaa (via GitHub)" <gi...@apache.org>.
Mandukhai-Alimaa commented on issue #457:
URL: https://github.com/apache/arrow-go/issues/457#issuecomment-3189150489
Yes, i will be updating the library incrementally. When I make the last PR, I will add the close tag inside the PR so this issue will be closed automatically when the last PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Alias `Record` to `RecordBatch` and soft-deprecate `Record` [arrow-go]
Posted by "ianmcook (via GitHub)" <gi...@apache.org>.
ianmcook commented on issue #457:
URL: https://github.com/apache/arrow-go/issues/457#issuecomment-3189078196
Partly resolved by #466 but work remains to update the library to use `RecordBatch` throughout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Alias `Record` to `RecordBatch` and soft-deprecate `Record` [arrow-go]
Posted by "prochac (via GitHub)" <gi...@apache.org>.
prochac commented on issue #457:
URL: https://github.com/apache/arrow-go/issues/457#issuecomment-3280718346
I also just hit the wall and left my comment here:
https://github.com/apache/arrow-go/commit/0606cfb49ee29c3badfa7cd12082133eda4062a1#r165607631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org