You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@falcon.apache.org by pa...@apache.org on 2018/04/17 08:53:38 UTC
falcon git commit: FALCON-2334 Tests in UpdateHelperTest suite fails
with ParentNotDirectoryException
Repository: falcon
Updated Branches:
refs/heads/master 272e999c1 -> 411d90c2f
FALCON-2334 Tests in UpdateHelperTest suite fails with ParentNotDirectoryException
The UpdateHelperTest tests fails with the following error :
`Parent path is not a directory: /var/lib/jenkins/workspace/falcon/common/target/falcon/tmp-hadoop-jenkins/jail-fs/testCluster/projects/falcon/staging/falcon/workflows/process/sample`
The errors occurs only when the EntityUtilTest#testIsStagingPath test runs before the tests mentioned above.
The following code in EntityUtilTest#testIsStagingPath creates a file at path - target/falcon/tmp-hadoop-jenkins/jail-fs/testCluster/projects/falcon/staging/falcon/workflows/process/sample which causes the error :
```
if (createPath && !fs.exists(path)) {
fs.create(path);
}
```
The change proposed in this pull request deletes the files created in EntityUtilTest#testIsStagingPath after the test checks are done.
Author: sonia-garudi <sg...@us.ibm.com>
Reviewers: @pallavi-rao
Closes #408 from sonia-garudi/FALCON-2334
Project: http://git-wip-us.apache.org/repos/asf/falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/falcon/commit/411d90c2
Tree: http://git-wip-us.apache.org/repos/asf/falcon/tree/411d90c2
Diff: http://git-wip-us.apache.org/repos/asf/falcon/diff/411d90c2
Branch: refs/heads/master
Commit: 411d90c2ffb59559770d23d4bd2f7675e46392e6
Parents: 272e999
Author: sonia-garudi <sg...@us.ibm.com>
Authored: Tue Apr 17 14:23:32 2018 +0530
Committer: pallavi-rao <pa...@inmobi.com>
Committed: Tue Apr 17 14:23:32 2018 +0530
----------------------------------------------------------------------
common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/falcon/blob/411d90c2/common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java
----------------------------------------------------------------------
diff --git a/common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java b/common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java
index 28a9270..1b07e75 100644
--- a/common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java
+++ b/common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java
@@ -395,6 +395,7 @@ public class EntityUtilTest extends AbstractTestBase {
}
Assert.assertEquals(EntityUtil.isStagingPath(cluster, process, path), expected);
+ fs.delete(path);
}
@DataProvider(name = "bundlePaths")