You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/09/28 03:26:47 UTC
[GitHub] [incubator-mxnet] barry-jin opened a new pull request #20617: [CI] Add Simple GitHub-Action Based License Checker
barry-jin opened a new pull request #20617:
URL: https://github.com/apache/incubator-mxnet/pull/20617
## Description ##
Add a simple license checker based on github action([apache/skywalking-eyes](https://github.com/apache/skywalking-eyes))
Note: For config file, I just copied [rat-excludes](https://github.com/apache/incubator-mxnet/blob/master/rat-excludes) into .licenserc.yaml. Will complete the config later.
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu merged pull request #20617: [CI] Add Simple GitHub-Action Based License Checker
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #20617:
URL: https://github.com/apache/incubator-mxnet/pull/20617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20617: [CI] Add Simple GitHub-Action Based License Checker
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20617:
URL: https://github.com/apache/incubator-mxnet/pull/20617#issuecomment-930345475
> I noticed you remove the ASF header from the np files. Could you explain the rational?
>
> > The term "third-party work" refers to a work not submitted directly to the ASF by the copyright owner or owner's agent. This includes parts of a work submitted directly to the ASF for which the submitter is not the copyright owner or owner's agent.
> > Do not modify or remove any copyright notices or licenses within third-party works.
> > Make sure that every third-party work includes its associated license, even if that requires adding a copy of the license from the third-party download site into the distribution.
> > Do not add the standard Apache License header to the top of third-party source files.
> > Minor modifications/additions to third-party source files should typically be licensed under the same terms as the rest of the third-party source for convenience.
> > The project's PMC should deal with major modifications/additions to third-party source files on a case-by-case basis.
>
> https://www.apache.org/legal/src-headers.html#3party
>
> As there are major modifications/additions to the source files to integrate with MXNet, ASF header was previously added. Of course we can revisit this decision and relicense. Can you document why?
As stated in the MXNet1.9.0 rc7 [voting thread](https://lists.apache.org/thread.html/r5789f5d93716d9d710b855775e71e4892fd37e41338c70c0855958ad%40%3Cgeneral.incubator.apache.org%3E), np_einsum_op.cc, np_einsum_op-inl.h and np_einsum_path_op-inl.h are adapted from numpy and they should stay under original license.
https://www.apache.org/legal/src-headers.html#3party
...
3. Do not add the standard Apache License header to the top of third-party source files.
...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20617: [CI] Add Simple GitHub-Action Based License Checker
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20617:
URL: https://github.com/apache/incubator-mxnet/pull/20617#issuecomment-929740117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20617: [CI] Add Simple GitHub-Action Based License Checker
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20617:
URL: https://github.com/apache/incubator-mxnet/pull/20617#issuecomment-929838472
@mxnet-bot run ci [website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #20617: [CI] Add Simple GitHub-Action Based License Checker
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20617:
URL: https://github.com/apache/incubator-mxnet/pull/20617#issuecomment-930467092
Nice work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #20617: [CI] Add Simple GitHub-Action Based License Checker
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #20617:
URL: https://github.com/apache/incubator-mxnet/pull/20617#issuecomment-930464935
> It depends on what you mean by significant, usually changes made to 3rd party files stay under the original license. See [1] on this, note that "Do not add the standard Apache License header to the top of third-party source files.”. If the license was to change, and the headers replaced then that needs to be noted in NOTICE. Please make sure that the license is noted in LICENSE.
https://lists.apache.org/thread.html/r4010c53f976819c94f3450469db8b936f7c15cb046a61f0d488674d3%40%3Cgeneral.incubator.apache.org%3E
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20617: [CI] Add Simple GitHub-Action Based License Checker
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20617:
URL: https://github.com/apache/incubator-mxnet/pull/20617#issuecomment-928710860
Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [clang, miscellaneous, edge, sanity, windows-gpu, windows-cpu, unix-cpu, centos-cpu, centos-gpu, unix-gpu, website]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu merged pull request #20617: [CI] Add Simple GitHub-Action Based License Checker
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #20617:
URL: https://github.com/apache/incubator-mxnet/pull/20617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #20617: [CI] Add Simple GitHub-Action Based License Checker
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #20617:
URL: https://github.com/apache/incubator-mxnet/pull/20617#issuecomment-930464935
> It depends on what you mean by significant, usually changes made to 3rd party files stay under the original license. See [1] on this, note that "Do not add the standard Apache License header to the top of third-party source files.”. If the license was to change, and the headers replaced then that needs to be noted in NOTICE. Please make sure that the license is noted in LICENSE.
https://lists.apache.org/thread.html/r4010c53f976819c94f3450469db8b936f7c15cb046a61f0d488674d3%40%3Cgeneral.incubator.apache.org%3E
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20617: [CI] Add Simple GitHub-Action Based License Checker
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20617:
URL: https://github.com/apache/incubator-mxnet/pull/20617#issuecomment-929740147
Jenkins CI successfully triggered : [centos-gpu, unix-cpu, unix-gpu, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20617: [CI] Add Simple GitHub-Action Based License Checker
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20617:
URL: https://github.com/apache/incubator-mxnet/pull/20617#issuecomment-930348232
This pull request is also addressing some additional license issues listed in #20616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20617: [CI] Add Simple GitHub-Action Based License Checker
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20617:
URL: https://github.com/apache/incubator-mxnet/pull/20617#issuecomment-929838510
Jenkins CI successfully triggered : [website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20617: [CI] Add Simple GitHub-Action Based License Checker
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20617:
URL: https://github.com/apache/incubator-mxnet/pull/20617#issuecomment-929740117
@mxnet-bot run ci [centos-gpu, unix-cpu, unix-gpu, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #20617: [CI] Add Simple GitHub-Action Based License Checker
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20617:
URL: https://github.com/apache/incubator-mxnet/pull/20617#issuecomment-930467092
Nice work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20617: [CI] Add Simple GitHub-Action Based License Checker
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20617:
URL: https://github.com/apache/incubator-mxnet/pull/20617#issuecomment-929740147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20617: [CI] Add Simple GitHub-Action Based License Checker
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20617:
URL: https://github.com/apache/incubator-mxnet/pull/20617#issuecomment-928710860
Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [clang, miscellaneous, edge, sanity, windows-gpu, windows-cpu, unix-cpu, centos-cpu, centos-gpu, unix-gpu, website]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org