You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Thomas Vandahl <tv...@apache.org> on 2014/03/29 15:49:18 UTC

[jcs] Attempt a 2.0 release

Hi folks,

I'd like to attempt a JCS release of version 2.0. I volunteer as the
release manager. However as this will be my first release within Commons
and I don't want to spoil it, I could need some mentoring. Anyone
willing to support me?

Bye, Thomas.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jcs] Attempt a 2.0 release

Posted by Benedikt Ritter <be...@gmail.com>.

Send from my mobile device

> Am 02.04.2014 um 12:19 schrieb sebb <se...@gmail.com>:
> 
>> On 2 April 2014 07:49, Thomas Vandahl <tv...@apache.org> wrote:
>>> On 01.04.14 00:25, sebb wrote:
>>> Also, there is a source tree called auxiliary-builds/jdk14.
>>> Since the code now targets 1.6, I assume this is no longer needed?
>> 
>> No. The source tree contains features (such as the JGroups cache) that
>> have not made it (yet) into the main code base. I had a hard time to
>> clean up the code as it was.
>> 
>>> Note that the Maven coordinates have changed and the package names
>>> have changed since 1.3.
>>> 
>>> Effectively 2.0 is a new product, so we should be careful to ensure
>>> that the API is sensible.
>>> For example, no non-private mutable fields (use getter/setter instead).
>>> Prefer immutable classes.
>> 
>> Quite a few of these are performance related.
> 
> Getters are unlikely to cause much if any performance hit compared
> with direct access as a decent compiler will inline them.
> But even if marginally slower they offer major benefits such as
> encapsulation and the possibility to improve thread-safety.
> 
> I doubt there is ever a genuine need to expose a mutable field.

I agree.

> 
>> Please feel free to add
>> some comments to the code where you see fit. I'll check the code and see
>> what I can do.
> 
> OK, will add some TODO comments.
> 
>> Bye, Thomas.
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jcs] Attempt a 2.0 release

Posted by sebb <se...@gmail.com>.
On 2 April 2014 07:49, Thomas Vandahl <tv...@apache.org> wrote:
> On 01.04.14 00:25, sebb wrote:
>> Also, there is a source tree called auxiliary-builds/jdk14.
>> Since the code now targets 1.6, I assume this is no longer needed?
>
> No. The source tree contains features (such as the JGroups cache) that
> have not made it (yet) into the main code base. I had a hard time to
> clean up the code as it was.
>
>> Note that the Maven coordinates have changed and the package names
>> have changed since 1.3.
>>
>> Effectively 2.0 is a new product, so we should be careful to ensure
>> that the API is sensible.
>> For example, no non-private mutable fields (use getter/setter instead).
>> Prefer immutable classes.
>
> Quite a few of these are performance related.

Getters are unlikely to cause much if any performance hit compared
with direct access as a decent compiler will inline them.
But even if marginally slower they offer major benefits such as
encapsulation and the possibility to improve thread-safety.

I doubt there is ever a genuine need to expose a mutable field.

> Please feel free to add
> some comments to the code where you see fit. I'll check the code and see
> what I can do.

OK, will add some TODO comments.

> Bye, Thomas.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jcs] Attempt a 2.0 release

Posted by Thomas Vandahl <tv...@apache.org>.
On 01.04.14 00:25, sebb wrote:
> Also, there is a source tree called auxiliary-builds/jdk14.
> Since the code now targets 1.6, I assume this is no longer needed?

No. The source tree contains features (such as the JGroups cache) that
have not made it (yet) into the main code base. I had a hard time to
clean up the code as it was.

> Note that the Maven coordinates have changed and the package names
> have changed since 1.3.
> 
> Effectively 2.0 is a new product, so we should be careful to ensure
> that the API is sensible.
> For example, no non-private mutable fields (use getter/setter instead).
> Prefer immutable classes.

Quite a few of these are performance related. Please feel free to add
some comments to the code where you see fit. I'll check the code and see
what I can do.

Bye, Thomas.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jcs] Attempt a 2.0 release

Posted by sebb <se...@gmail.com>.
Also, there is a source tree called auxiliary-builds/jdk14.
Since the code now targets 1.6, I assume this is no longer needed?

Note that the Maven coordinates have changed and the package names
have changed since 1.3.

Effectively 2.0 is a new product, so we should be careful to ensure
that the API is sensible.
For example, no non-private mutable fields (use getter/setter instead).
Prefer immutable classes.



On 31 March 2014 23:06, sebb <se...@gmail.com> wrote:
> Just been looking at the dependencies.
> Some of these are obsolete, for example commons-httpclient 3.0.1
>
> On 31 March 2014 22:56, sebb <se...@gmail.com> wrote:
>> The Continuum build reports lots of test failures.
>>
>> For example:
>>
>> https://continuum-ci.apache.org/continuum/buildResult.action?buildId=28476&projectId=286
>>
>> The tests are very "noisy" when run interactively.
>> This makes it difficult to pick out the test failures.
>> Ideally tests should produce no output except on failure.
>>
>> I think the test failures need to be fixed before a release can be considered.
>>
>> On 31 March 2014 19:40, Benedikt Ritter <be...@gmail.com> wrote:
>>> Hi Thomas,
>>>
>>> for the download plugin to work, you need to set some properties in
>>> pom.xml. Have a, look at commons lang:
>>>
>>>     <commons.componentid>lang3</commons.componentid>
>>>     <!-- Current 3.x release series -->
>>>     <commons.release.version>3.3.2</commons.release.version>
>>>     <commons.release.desc>(Java 6.0+)</commons.release.desc>
>>>
>>> I do not use the release profile to be honest. I usually follow the guide
>>> at [1] and do this stuff manually.
>>>
>>> Benedikt
>>>
>>> [1] http://commons.apache.org/releases/prepare.html
>>>
>>>
>>>
>>> 2014-03-31 14:21 GMT+02:00 Benedikt Ritter <be...@gmail.com>:
>>>
>>>> Hey Thomas,
>>>>
>>>> I'll habe a look tonight, when I'm at home and give you some feedback.
>>>>
>>>> Benedikt
>>>>
>>>> Send from my mobile device
>>>>
>>>> > Am 29.03.2014 um 23:03 schrieb Thomas Vandahl <tv...@apache.org>:
>>>> >
>>>> > Hi Benedikt,
>>>> >
>>>> >> On 29.03.14 16:58, Benedikt Ritter wrote:
>>>> >> I've released [lang] a few times. I can help. Feel free to drop any
>>>> issues here in the list, of get in touch with me in our IRC channel.
>>>> >
>>>> > Thanks a lot. Indeed, I already have two questions.
>>>> >
>>>> > - How is the download plugin supposed to work? The generated XML file
>>>> > looks as if there are some placeholders in it that are supposed to be
>>>> > replaced but aren't.
>>>> >
>>>> > - How do I activate the commons release profile in the Maven build?
>>>> > Somehow this is not triggered by the maven release plugin alone. At
>>>> > least my assemblies are not being used.
>>>> >
>>>> > Bye, Thomas.
>>>> >
>>>> > ---------------------------------------------------------------------
>>>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> > For additional commands, e-mail: dev-help@commons.apache.org
>>>> >
>>>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jcs] Attempt a 2.0 release

Posted by Thomas Vandahl <tv...@apache.org>.
On 02.04.14 12:13, sebb wrote:
> On 2 April 2014 07:42, Thomas Vandahl <tv...@apache.org> wrote:
>> On 01.04.14 00:06, sebb wrote:
>>> Just been looking at the dependencies.
>>> Some of these are obsolete, for example commons-httpclient 3.0.1
>>
>> What do you mean by "obsolete"?
> 
> No longer supported.
> 
>> Use 4.x? Or remove the dependency
>> completely?
> 
> Depends on what the dependency is needed for.
> Does it provide essential functionality?
> Is it worth maintaining it going forward?
>
Well, it's used in the RemoteHttpCaches, see
org.apache.commons.jcs.auxiliary.remote.http.client.AbstractHttpClient
for example. So I understand this needs updating?

Bye, Thomas.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jcs] Attempt a 2.0 release

Posted by sebb <se...@gmail.com>.
On 2 April 2014 07:42, Thomas Vandahl <tv...@apache.org> wrote:
> On 01.04.14 00:06, sebb wrote:
>> Just been looking at the dependencies.
>> Some of these are obsolete, for example commons-httpclient 3.0.1
>
> What do you mean by "obsolete"?

No longer supported.

> Use 4.x? Or remove the dependency
> completely?

Depends on what the dependency is needed for.
Does it provide essential functionality?
Is it worth maintaining it going forward?

> Bye, Thomas.
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jcs] Attempt a 2.0 release

Posted by Thomas Vandahl <tv...@apache.org>.
On 01.04.14 00:06, sebb wrote:
> Just been looking at the dependencies.
> Some of these are obsolete, for example commons-httpclient 3.0.1

What do you mean by "obsolete"? Use 4.x? Or remove the dependency
completely?

Bye, Thomas.



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jcs] Attempt a 2.0 release

Posted by sebb <se...@gmail.com>.
Just been looking at the dependencies.
Some of these are obsolete, for example commons-httpclient 3.0.1

On 31 March 2014 22:56, sebb <se...@gmail.com> wrote:
> The Continuum build reports lots of test failures.
>
> For example:
>
> https://continuum-ci.apache.org/continuum/buildResult.action?buildId=28476&projectId=286
>
> The tests are very "noisy" when run interactively.
> This makes it difficult to pick out the test failures.
> Ideally tests should produce no output except on failure.
>
> I think the test failures need to be fixed before a release can be considered.
>
> On 31 March 2014 19:40, Benedikt Ritter <be...@gmail.com> wrote:
>> Hi Thomas,
>>
>> for the download plugin to work, you need to set some properties in
>> pom.xml. Have a, look at commons lang:
>>
>>     <commons.componentid>lang3</commons.componentid>
>>     <!-- Current 3.x release series -->
>>     <commons.release.version>3.3.2</commons.release.version>
>>     <commons.release.desc>(Java 6.0+)</commons.release.desc>
>>
>> I do not use the release profile to be honest. I usually follow the guide
>> at [1] and do this stuff manually.
>>
>> Benedikt
>>
>> [1] http://commons.apache.org/releases/prepare.html
>>
>>
>>
>> 2014-03-31 14:21 GMT+02:00 Benedikt Ritter <be...@gmail.com>:
>>
>>> Hey Thomas,
>>>
>>> I'll habe a look tonight, when I'm at home and give you some feedback.
>>>
>>> Benedikt
>>>
>>> Send from my mobile device
>>>
>>> > Am 29.03.2014 um 23:03 schrieb Thomas Vandahl <tv...@apache.org>:
>>> >
>>> > Hi Benedikt,
>>> >
>>> >> On 29.03.14 16:58, Benedikt Ritter wrote:
>>> >> I've released [lang] a few times. I can help. Feel free to drop any
>>> issues here in the list, of get in touch with me in our IRC channel.
>>> >
>>> > Thanks a lot. Indeed, I already have two questions.
>>> >
>>> > - How is the download plugin supposed to work? The generated XML file
>>> > looks as if there are some placeholders in it that are supposed to be
>>> > replaced but aren't.
>>> >
>>> > - How do I activate the commons release profile in the Maven build?
>>> > Somehow this is not triggered by the maven release plugin alone. At
>>> > least my assemblies are not being used.
>>> >
>>> > Bye, Thomas.
>>> >
>>> > ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> > For additional commands, e-mail: dev-help@commons.apache.org
>>> >
>>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jcs] Attempt a 2.0 release

Posted by Johannes Weberhofer <jw...@weberhofer.at>.
After your latest changes the output looks much better now.

java version "1.7.0_51"
OpenJDK Runtime Environment (IcedTea 2.4.4) (suse-24.13.5-x86_64)
OpenJDK 64-Bit Server VM (build 24.45-b08, mixed mode)


Results :
Tests run: 396, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:10.204s
[INFO] Finished at: Wed Apr 02 16:12:23 CEST 2014
[INFO] Final Memory: 20M/174M
[INFO] ------------------------------------------------------------------------



Am 02.04.2014 13:57, schrieb Johannes Weberhofer:
> Am 02.04.2014 08:41, schrieb Thomas Vandahl:
>> On 31.03.14 23:56, sebb wrote:
>>> The Continuum build reports lots of test failures.
>>>
>>> For example:
>>>
>>> https://continuum-ci.apache.org/continuum/buildResult.action?buildId=28476&projectId=286
>>>
>>> The tests are very "noisy" when run interactively.
>>> This makes it difficult to pick out the test failures.
>>> Ideally tests should produce no output except on failure.
>>>
>>> I think the test failures need to be fixed before a release can be considered.
>>
>> Absolutely agree. Problem is, however, that the tests run fine here (Mac
>> OS Snow Leopard) and it is difficult for me to reproduce the Continuum
>> environment. Does the build run successful when you run it locally?
>>
>> Bye, Thomas.
>
> On Linux I see one stacktrace but all tests pass without errors; https://issues.apache.org/jira/browse/JCS-110 seems to be solved for me.
>
> Johannes
>
> ---------------------------Memory Cache
> List Size = 0
> Map Size = 0
> Put Count = 1
> Hit Count = 1
> Miss Count = 1
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.461 sec - in org.apache.commons.jcs.auxiliary.remote.server.BasicRemoteCacheClientServerUnitTest
> Running org.apache.commons.jcs.auxiliary.remote.server.TimeoutConfigurableRMIScoketFactoryUnitTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.024 sec - in org.apache.commons.jcs.auxiliary.remote.server.TimeoutConfigurableRMIScoketFactoryUnitTest
> Running org.apache.commons.jcs.auxiliary.remote.util.RemoteCacheRequestFactoryUnitTest
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.124 sec - in org.apache.commons.jcs.auxiliary.remote.util.RemoteCacheRequestFactoryUnitTest
> Running org.apache.commons.jcs.auxiliary.remote.RemoteUtilsUnitTest
> java.rmi.server.ExportException: internal error: ObjID already in use
>      at sun.rmi.transport.ObjectTable.putTarget(ObjectTable.java:169)
>      at sun.rmi.transport.Transport.exportObject(Transport.java:74)
>      at sun.rmi.transport.tcp.TCPTransport.exportObject(TCPTransport.java:229)
>      at sun.rmi.transport.tcp.TCPEndpoint.exportObject(TCPEndpoint.java:393)
>      at sun.rmi.transport.LiveRef.exportObject(LiveRef.java:129)
>      at sun.rmi.server.UnicastServerRef.exportObject(UnicastServerRef.java:188)
>      at sun.rmi.registry.RegistryImpl.setup(RegistryImpl.java:100)
>      at sun.rmi.registry.RegistryImpl.<init>(RegistryImpl.java:86)
>      at java.rmi.registry.LocateRegistry.createRegistry(LocateRegistry.java:186)
>      at org.apache.commons.jcs.auxiliary.remote.RemoteUtils.createRegistry(RemoteUtils.java:81)
>      at org.apache.commons.jcs.auxiliary.remote.RemoteUtilsUnitTest.testCreateRegistryTwice(RemoteUtilsUnitTest.java:53)
>      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>      at java.lang.reflect.Method.invoke(Method.java:597)
>      at junit.framework.TestCase.runTest(TestCase.java:154)
>      at junit.framework.TestCase.runBare(TestCase.java:127)
>      at junit.framework.TestResult$1.protect(TestResult.java:106)
>      at junit.framework.TestResult.runProtected(TestResult.java:124)
>      at junit.framework.TestResult.run(TestResult.java:109)
>      at junit.framework.TestCase.run(TestCase.java:118)
>      at junit.framework.TestSuite.runTest(TestSuite.java:208)
>      at junit.framework.TestSuite.run(TestSuite.java:203)
>      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>      at java.lang.reflect.Method.invoke(Method.java:597)
>      at org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:95)
>      at org.apache.maven.surefire.junit.JUnit3Provider.executeTestSet(JUnit3Provider.java:131)
>      at org.apache.maven.surefire.junit.JUnit3Provider.invoke(JUnit3Provider.java:108)
>      at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
>      at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
>      at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.157 sec - in org.apache.commons.jcs.auxiliary.remote.RemoteUtilsUnitTest
> Running org.apache.commons.jcs.auxiliary.remote.RemoteCacheNoWaitUnitTest
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.252 sec - in org.apache.commons.jcs.auxiliary.remote.RemoteCacheNoWaitUnitTest
> Running org.apache.commons.jcs.auxiliary.remote.RemoteCacheListenerUnitTest
> Creating mock cache
> Creating mock cache
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.22 sec - in org.apache.commons.jcs.auxiliary.remote.RemoteCacheListenerUnitTest
> Running org.apache.commons.jcs.auxiliary.remote.ZombieRemoteCacheServiceUnitTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.139 sec - in org.apache.commons.jcs.auxiliary.remote.ZombieRemoteCacheServiceUnitTest
> Running org.apache.commons.jcs.auxiliary.remote.RemoteCacheUnitTest
> Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.17 sec - in org.apache.commons.jcs.auxiliary.remote.RemoteCacheUnitTest
> Running org.apache.commons.jcs.auxiliary.disk.file.FileDiskCacheFactoryUnitTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.169 sec - in org.apache.commons.jcs.auxiliary.disk.file.FileDiskCacheFactoryUnitTest
> Running org.apache.commons.jcs.auxiliary.disk.file.FileDiskCacheUnitTest
> afterElement = [CacheElement: cacheName [testPutGet_BigString], key [x], val [This is my big string ABCDEFGH 0This is my big string ABCDEFGH 1This is my big string ABCDEFGH 0This is my big string ABCDEFGH 2This is my big string ABCDEFGH 0This is my big string ABCDEFGH 1This is my big string ABCDEFGH 0This is my big string ABCDEFGH 3This is my big string ABCDEFGH 0This is my big string ABCDEFGH 1This is my big string ABCDEFGH 0This is my big string ABCDEFGH 2This is my big string ABCDEFGH 0This is my big string ABCDEFGH 1This is my big string ABCDEFGH 0This is my big string ABCDEFGH], attr [null]
> Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.509 sec - in org.apache.commons.jcs.auxiliary.disk.file.FileDiskCacheUnitTest
> Running org.apache.commons.jcs.auxiliary.disk.jdbc.mysql.util.ScheduleParserUtilUnitTest
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.026 sec - in org.apache.commons.jcs.auxiliary.disk.jdbc.mysql.util.ScheduleParserUtilUnitTest
> Running org.apache.commons.jcs.auxiliary.disk.jdbc.mysql.MySQLDiskCacheManagerUnitTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.282 sec - in org.apache.commons.jcs.auxiliary.disk.jdbc.mysql.MySQLDiskCacheManagerUnitTest
> Running org.apache.commons.jcs.auxiliary.disk.jdbc.mysql.MySQLDiskCacheUnitTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.299 sec - in org.apache.commons.jcs.auxiliary.disk.jdbc.mysql.MySQLDiskCacheUnitTest
> Running org.apache.commons.jcs.auxiliary.disk.jdbc.mysql.MySQLDiskCacheHsqlBackedUnitTest
> BEFORE PUT
> Region Name = testCache2
> HitCountRam = 0
> HitCountAux = 0
>
>
>

-- 
Johannes Weberhofer
Weberhofer GmbH, Austria, Vienna

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jcs] Attempt a 2.0 release

Posted by Johannes Weberhofer <jw...@weberhofer.at>.
Am 02.04.2014 08:41, schrieb Thomas Vandahl:
> On 31.03.14 23:56, sebb wrote:
>> The Continuum build reports lots of test failures.
>>
>> For example:
>>
>> https://continuum-ci.apache.org/continuum/buildResult.action?buildId=28476&projectId=286
>>
>> The tests are very "noisy" when run interactively.
>> This makes it difficult to pick out the test failures.
>> Ideally tests should produce no output except on failure.
>>
>> I think the test failures need to be fixed before a release can be considered.
>
> Absolutely agree. Problem is, however, that the tests run fine here (Mac
> OS Snow Leopard) and it is difficult for me to reproduce the Continuum
> environment. Does the build run successful when you run it locally?
>
> Bye, Thomas.

On Linux I see one stacktrace but all tests pass without errors; https://issues.apache.org/jira/browse/JCS-110 seems to be solved for me.

Johannes

---------------------------Memory Cache
List Size = 0
Map Size = 0
Put Count = 1
Hit Count = 1
Miss Count = 1
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.461 sec - in org.apache.commons.jcs.auxiliary.remote.server.BasicRemoteCacheClientServerUnitTest
Running org.apache.commons.jcs.auxiliary.remote.server.TimeoutConfigurableRMIScoketFactoryUnitTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.024 sec - in org.apache.commons.jcs.auxiliary.remote.server.TimeoutConfigurableRMIScoketFactoryUnitTest
Running org.apache.commons.jcs.auxiliary.remote.util.RemoteCacheRequestFactoryUnitTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.124 sec - in org.apache.commons.jcs.auxiliary.remote.util.RemoteCacheRequestFactoryUnitTest
Running org.apache.commons.jcs.auxiliary.remote.RemoteUtilsUnitTest
java.rmi.server.ExportException: internal error: ObjID already in use
	at sun.rmi.transport.ObjectTable.putTarget(ObjectTable.java:169)
	at sun.rmi.transport.Transport.exportObject(Transport.java:74)
	at sun.rmi.transport.tcp.TCPTransport.exportObject(TCPTransport.java:229)
	at sun.rmi.transport.tcp.TCPEndpoint.exportObject(TCPEndpoint.java:393)
	at sun.rmi.transport.LiveRef.exportObject(LiveRef.java:129)
	at sun.rmi.server.UnicastServerRef.exportObject(UnicastServerRef.java:188)
	at sun.rmi.registry.RegistryImpl.setup(RegistryImpl.java:100)
	at sun.rmi.registry.RegistryImpl.<init>(RegistryImpl.java:86)
	at java.rmi.registry.LocateRegistry.createRegistry(LocateRegistry.java:186)
	at org.apache.commons.jcs.auxiliary.remote.RemoteUtils.createRegistry(RemoteUtils.java:81)
	at org.apache.commons.jcs.auxiliary.remote.RemoteUtilsUnitTest.testCreateRegistryTwice(RemoteUtilsUnitTest.java:53)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at junit.framework.TestCase.runTest(TestCase.java:154)
	at junit.framework.TestCase.runBare(TestCase.java:127)
	at junit.framework.TestResult$1.protect(TestResult.java:106)
	at junit.framework.TestResult.runProtected(TestResult.java:124)
	at junit.framework.TestResult.run(TestResult.java:109)
	at junit.framework.TestCase.run(TestCase.java:118)
	at junit.framework.TestSuite.runTest(TestSuite.java:208)
	at junit.framework.TestSuite.run(TestSuite.java:203)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:95)
	at org.apache.maven.surefire.junit.JUnit3Provider.executeTestSet(JUnit3Provider.java:131)
	at org.apache.maven.surefire.junit.JUnit3Provider.invoke(JUnit3Provider.java:108)
	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.157 sec - in org.apache.commons.jcs.auxiliary.remote.RemoteUtilsUnitTest
Running org.apache.commons.jcs.auxiliary.remote.RemoteCacheNoWaitUnitTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.252 sec - in org.apache.commons.jcs.auxiliary.remote.RemoteCacheNoWaitUnitTest
Running org.apache.commons.jcs.auxiliary.remote.RemoteCacheListenerUnitTest
Creating mock cache
Creating mock cache
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.22 sec - in org.apache.commons.jcs.auxiliary.remote.RemoteCacheListenerUnitTest
Running org.apache.commons.jcs.auxiliary.remote.ZombieRemoteCacheServiceUnitTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.139 sec - in org.apache.commons.jcs.auxiliary.remote.ZombieRemoteCacheServiceUnitTest
Running org.apache.commons.jcs.auxiliary.remote.RemoteCacheUnitTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.17 sec - in org.apache.commons.jcs.auxiliary.remote.RemoteCacheUnitTest
Running org.apache.commons.jcs.auxiliary.disk.file.FileDiskCacheFactoryUnitTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.169 sec - in org.apache.commons.jcs.auxiliary.disk.file.FileDiskCacheFactoryUnitTest
Running org.apache.commons.jcs.auxiliary.disk.file.FileDiskCacheUnitTest
afterElement = [CacheElement: cacheName [testPutGet_BigString], key [x], val [This is my big string ABCDEFGH 0This is my big string ABCDEFGH 1This is my big string ABCDEFGH 0This is my big string ABCDEFGH 2This is my big string ABCDEFGH 0This is my big string ABCDEFGH 1This is my big string ABCDEFGH 0This is my big string ABCDEFGH 3This is my big string ABCDEFGH 0This is my big string ABCDEFGH 1This is my big string ABCDEFGH 0This is my big string ABCDEFGH 2This is my big string ABCDEFGH 0This is my big string ABCDEFGH 1This is my big string ABCDEFGH 0This is my big string ABCDEFGH], attr [null]
Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.509 sec - in org.apache.commons.jcs.auxiliary.disk.file.FileDiskCacheUnitTest
Running org.apache.commons.jcs.auxiliary.disk.jdbc.mysql.util.ScheduleParserUtilUnitTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.026 sec - in org.apache.commons.jcs.auxiliary.disk.jdbc.mysql.util.ScheduleParserUtilUnitTest
Running org.apache.commons.jcs.auxiliary.disk.jdbc.mysql.MySQLDiskCacheManagerUnitTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.282 sec - in org.apache.commons.jcs.auxiliary.disk.jdbc.mysql.MySQLDiskCacheManagerUnitTest
Running org.apache.commons.jcs.auxiliary.disk.jdbc.mysql.MySQLDiskCacheUnitTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.299 sec - in org.apache.commons.jcs.auxiliary.disk.jdbc.mysql.MySQLDiskCacheUnitTest
Running org.apache.commons.jcs.auxiliary.disk.jdbc.mysql.MySQLDiskCacheHsqlBackedUnitTest
BEFORE PUT
Region Name = testCache2
HitCountRam = 0
HitCountAux = 0



-- 
Johannes Weberhofer
Weberhofer GmbH, Austria, Vienna

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jcs] Attempt a 2.0 release

Posted by Thomas Vandahl <tv...@apache.org>.
On 02.04.14 12:23, sebb wrote:
> However I assume the tests are still "noisy" on MacOS.
> Once the unnecessary output is removed, can look at adding temporary
> additional debug for the failing test cases in Continuum.

Yes, I directed logging to a log file and removed some of the chatter.
We'll see if that helps.

Bye, Thomas.



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jcs] Attempt a 2.0 release

Posted by sebb <se...@gmail.com>.
On 2 April 2014 07:41, Thomas Vandahl <tv...@apache.org> wrote:
> On 31.03.14 23:56, sebb wrote:
>> The Continuum build reports lots of test failures.
>>
>> For example:
>>
>> https://continuum-ci.apache.org/continuum/buildResult.action?buildId=28476&projectId=286
>>
>> The tests are very "noisy" when run interactively.
>> This makes it difficult to pick out the test failures.
>> Ideally tests should produce no output except on failure.
>>
>> I think the test failures need to be fixed before a release can be considered.
>
> Absolutely agree. Problem is, however, that the tests run fine here (Mac
> OS Snow Leopard) and it is difficult for me to reproduce the Continuum
> environment. Does the build run successful when you run it locally?

No, I have the same issues on WinXP.

However I assume the tests are still "noisy" on MacOS.
Once the unnecessary output is removed, can look at adding temporary
additional debug for the failing test cases in Continuum.

> Bye, Thomas.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jcs] Attempt a 2.0 release

Posted by Thomas Vandahl <tv...@apache.org>.
On 31.03.14 23:56, sebb wrote:
> The Continuum build reports lots of test failures.
> 
> For example:
> 
> https://continuum-ci.apache.org/continuum/buildResult.action?buildId=28476&projectId=286
> 
> The tests are very "noisy" when run interactively.
> This makes it difficult to pick out the test failures.
> Ideally tests should produce no output except on failure.
> 
> I think the test failures need to be fixed before a release can be considered.

Absolutely agree. Problem is, however, that the tests run fine here (Mac
OS Snow Leopard) and it is difficult for me to reproduce the Continuum
environment. Does the build run successful when you run it locally?

Bye, Thomas.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jcs] Attempt a 2.0 release

Posted by sebb <se...@gmail.com>.
The Continuum build reports lots of test failures.

For example:

https://continuum-ci.apache.org/continuum/buildResult.action?buildId=28476&projectId=286

The tests are very "noisy" when run interactively.
This makes it difficult to pick out the test failures.
Ideally tests should produce no output except on failure.

I think the test failures need to be fixed before a release can be considered.

On 31 March 2014 19:40, Benedikt Ritter <be...@gmail.com> wrote:
> Hi Thomas,
>
> for the download plugin to work, you need to set some properties in
> pom.xml. Have a, look at commons lang:
>
>     <commons.componentid>lang3</commons.componentid>
>     <!-- Current 3.x release series -->
>     <commons.release.version>3.3.2</commons.release.version>
>     <commons.release.desc>(Java 6.0+)</commons.release.desc>
>
> I do not use the release profile to be honest. I usually follow the guide
> at [1] and do this stuff manually.
>
> Benedikt
>
> [1] http://commons.apache.org/releases/prepare.html
>
>
>
> 2014-03-31 14:21 GMT+02:00 Benedikt Ritter <be...@gmail.com>:
>
>> Hey Thomas,
>>
>> I'll habe a look tonight, when I'm at home and give you some feedback.
>>
>> Benedikt
>>
>> Send from my mobile device
>>
>> > Am 29.03.2014 um 23:03 schrieb Thomas Vandahl <tv...@apache.org>:
>> >
>> > Hi Benedikt,
>> >
>> >> On 29.03.14 16:58, Benedikt Ritter wrote:
>> >> I've released [lang] a few times. I can help. Feel free to drop any
>> issues here in the list, of get in touch with me in our IRC channel.
>> >
>> > Thanks a lot. Indeed, I already have two questions.
>> >
>> > - How is the download plugin supposed to work? The generated XML file
>> > looks as if there are some placeholders in it that are supposed to be
>> > replaced but aren't.
>> >
>> > - How do I activate the commons release profile in the Maven build?
>> > Somehow this is not triggered by the maven release plugin alone. At
>> > least my assemblies are not being used.
>> >
>> > Bye, Thomas.
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> > For additional commands, e-mail: dev-help@commons.apache.org
>> >
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jcs] Attempt a 2.0 release

Posted by Benedikt Ritter <be...@gmail.com>.
Hi Thomas,

for the download plugin to work, you need to set some properties in
pom.xml. Have a, look at commons lang:

    <commons.componentid>lang3</commons.componentid>
    <!-- Current 3.x release series -->
    <commons.release.version>3.3.2</commons.release.version>
    <commons.release.desc>(Java 6.0+)</commons.release.desc>

I do not use the release profile to be honest. I usually follow the guide
at [1] and do this stuff manually.

Benedikt

[1] http://commons.apache.org/releases/prepare.html



2014-03-31 14:21 GMT+02:00 Benedikt Ritter <be...@gmail.com>:

> Hey Thomas,
>
> I'll habe a look tonight, when I'm at home and give you some feedback.
>
> Benedikt
>
> Send from my mobile device
>
> > Am 29.03.2014 um 23:03 schrieb Thomas Vandahl <tv...@apache.org>:
> >
> > Hi Benedikt,
> >
> >> On 29.03.14 16:58, Benedikt Ritter wrote:
> >> I've released [lang] a few times. I can help. Feel free to drop any
> issues here in the list, of get in touch with me in our IRC channel.
> >
> > Thanks a lot. Indeed, I already have two questions.
> >
> > - How is the download plugin supposed to work? The generated XML file
> > looks as if there are some placeholders in it that are supposed to be
> > replaced but aren't.
> >
> > - How do I activate the commons release profile in the Maven build?
> > Somehow this is not triggered by the maven release plugin alone. At
> > least my assemblies are not being used.
> >
> > Bye, Thomas.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>

Re: [jcs] Attempt a 2.0 release

Posted by Benedikt Ritter <be...@gmail.com>.
Hey Thomas,

I'll habe a look tonight, when I'm at home and give you some feedback.

Benedikt

Send from my mobile device

> Am 29.03.2014 um 23:03 schrieb Thomas Vandahl <tv...@apache.org>:
> 
> Hi Benedikt,
> 
>> On 29.03.14 16:58, Benedikt Ritter wrote:
>> I've released [lang] a few times. I can help. Feel free to drop any issues here in the list, of get in touch with me in our IRC channel.
> 
> Thanks a lot. Indeed, I already have two questions.
> 
> - How is the download plugin supposed to work? The generated XML file
> looks as if there are some placeholders in it that are supposed to be
> replaced but aren't.
> 
> - How do I activate the commons release profile in the Maven build?
> Somehow this is not triggered by the maven release plugin alone. At
> least my assemblies are not being used.
> 
> Bye, Thomas.
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jcs] Attempt a 2.0 release

Posted by Thomas Vandahl <tv...@apache.org>.
Hi Benedikt,

On 29.03.14 16:58, Benedikt Ritter wrote:
> I've released [lang] a few times. I can help. Feel free to drop any issues here in the list, of get in touch with me in our IRC channel.

Thanks a lot. Indeed, I already have two questions.

- How is the download plugin supposed to work? The generated XML file
looks as if there are some placeholders in it that are supposed to be
replaced but aren't.

- How do I activate the commons release profile in the Maven build?
Somehow this is not triggered by the maven release plugin alone. At
least my assemblies are not being used.

Bye, Thomas.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jcs] Attempt a 2.0 release

Posted by Benedikt Ritter <be...@gmail.com>.
Hi Thomas,

I've released [lang] a few times. I can help. Feel free to drop any issues here in the list, of get in touch with me in our IRC channel.

Benedikt

Send from my mobile device

> Am 29.03.2014 um 15:49 schrieb Thomas Vandahl <tv...@apache.org>:
> 
> Hi folks,
> 
> I'd like to attempt a JCS release of version 2.0. I volunteer as the
> release manager. However as this will be my first release within Commons
> and I don't want to spoil it, I could need some mentoring. Anyone
> willing to support me?
> 
> Bye, Thomas.
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org