You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@logging.apache.org by sd...@apache.org on 2007/11/17 01:55:39 UTC
svn commit: r595887 -
/logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanel.java
Author: sdeboy
Date: Fri Nov 16 16:55:37 2007
New Revision: 595887
URL: http://svn.apache.org/viewvc?rev=595887&view=rev
Log:
Fix accidental short-circuit evaluation dropping all but 1st row in batch
Modified:
logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanel.java
Modified: logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanel.java
URL: http://svn.apache.org/viewvc/logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanel.java?rev=595887&r1=595886&r2=595887&view=diff
==============================================================================
--- logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanel.java (original)
+++ logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanel.java Fri Nov 16 16:55:37 2007
@@ -1415,7 +1415,8 @@
updateOtherModels(event);
- rowAdded = rowAdded || tableModel.isAddRow(event);
+ boolean isCurrentRowAdded = tableModel.isAddRow(event);
+ rowAdded = rowAdded || isCurrentRowAdded;
}
//tell the model to notify the count listeners
@@ -1425,7 +1426,7 @@
if (tableModel.isSortEnabled()) {
tableModel.sort();
}
-
+
//always update detail pane (since we may be using a cyclic buffer which is full)
detailPaneUpdater.setSelectedRow(table.getSelectedRow());
}