You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/03 07:41:40 UTC
[GitHub] [spark] yaooqinn opened a new pull request #33908: [SPARK-36662][SQL] special timestamps support for path filters - modifiedBefore/modifiedAfter
yaooqinn opened a new pull request #33908:
URL: https://github.com/apache/spark/pull/33908
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Special timestamps support for path filters - modifiedBefore/modifiedAfter
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
theses special values can be useful to be supported in path filters - modifiedBefore/modifiedAfter. e.g. for daily scheduled jobs
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
yes, special timestamps are supported by modifiedBefore/modifiedAfter
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
newly added tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913470622
I'm not a native speaker of English, so please correct me if I'm mistaken.
* "Spark will read the files which are modified before yesterday."
* "Spark will read the files which are modified after yesterday."
For me, I expect the same behavior from both sentences, "exclude them written in yesterday". The point of time represented as "yesterday' in both sentences are different. That said, Spark will show different behavior with natural language. That is due to the conversion of "date" representation to "timestamp".
I understand that the timestamp format is probably not convenient enough to use in some cases. I'm fine if everyone is OK with the new notion, but I'd rather address the other case relatively harder to represent as such timestamp format, intervals like "before 24 hours" which is relative to the current timestamp. The result is still the unit of timestamp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913408686
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47514/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913369610
updated the pr description and the sql doc too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-1001086254
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913444068
> For me, all files modified in yesterday should be excluded in both sentences, but it won't be interpreted like that if we consider the semantic of "yesterday" as yesterday "00:00:00".
When `yesterday` is a timestamp, it represents the point of the midnight of yesterday, see https://github.com/apache/spark/pull/33908/files#diff-6c1794137bfd408f6c785c42e67e82a82fce70d78560fa795c3bac2886b21b38R140.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913377220
**[Test build #143012 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143012/testReport)** for PR 33908 at commit [`a3b7d08`](https://github.com/apache/spark/commit/a3b7d08983115c84225ce52f8db3dd16efd5471e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912711978
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47488/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #33908:
URL: https://github.com/apache/spark/pull/33908#discussion_r702047295
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/PathFilterSuite.scala
##########
@@ -222,6 +222,19 @@ class PathFilterSuite extends QueryTest with SharedSparkSession {
}
}
+ test("SPARK-36662: special timestamps support for path filters - modifiedBefore/modifiedAfter") {
+ withTempPath { path =>
+ val dataDir = path.getCanonicalPath
+ Seq("foo").toDS().write.text(dataDir)
+ val df = spark.read.option("modifiedbefore", "yesterday").text(dataDir)
+ assert(df.isEmpty)
+
+ // Both glob pattern in option and path should be effective to filter files.
+ val df2 = spark.read.option("modifiedbefore", "tomorrow").text(dataDir)
Review comment:
nice suggestion, just add 2 more test cases for modifiedAfter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912831286
**[Test build #142987 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142987/testReport)** for PR 33908 at commit [`74c4aad`](https://github.com/apache/spark/commit/74c4aad34c445b774468f3f5f7aa3943b01b6c83).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #33908:
URL: https://github.com/apache/spark/pull/33908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912721690
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47488/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912721690
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47488/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn edited a comment on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
yaooqinn edited a comment on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913410946
The current implementation also accepts timestamps in an incomplete form like, `2021-09`, `2021-09-30`.
We can replace these values with both sentences above, what happens to September or 30th, September 2021? Seems the same as `yesterday` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913438275
The confusion on time unit on second makes an error of "second". We don't care much about "millisecond" precision on the modified date in file, because we can't predict it. Please let me know if your use case needs to classify the millisecond precision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-920537614
> These special datetime strings are like functions and we should limit where they can be used. For this particular use case, I think the spark application is able to generate the timestamp string for yesterday/today/tomorrow?
I think the behavior is unambiguous and clear to the system but may not be that clear to human thought, which seems not a problem to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33908: [SPARK-36662][SQL] special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912352109
**[Test build #142971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142971/testReport)** for PR 33908 at commit [`dc1e0fe`](https://github.com/apache/spark/commit/dc1e0fe731be5ee5854083c92f0ffbfb4ceada65).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913428847
How about the modified events between the specific one second when using before/after 2020-06-01T13:00:00? what are the differences when the time unit is day or second?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912690104
**[Test build #142987 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142987/testReport)** for PR 33908 at commit [`74c4aad`](https://github.com/apache/spark/commit/74c4aad34c445b774468f3f5f7aa3943b01b6c83).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913408686
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47514/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33908: [SPARK-36662][SQL] special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912360807
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47472/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913355033
We have `modifiedBefore` and `modifiedAfter` options but don't have the support of special timestamps yet. @yaooqinn mind showing a self-contained example in the Pr description and clarify which special timestamps will be supported after this Pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913570850
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143012/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913425061
I'd rather say that should be considered as a bug instead of justifying the current behavior.
The behavior of being able to specify incomplete format of timestamp is NOT an intention. The doc is very clear about the format of timestamp - `The provided timestamp must be in the following format: YYYY-MM-DDTHH:mm:ss (e.g. 2020-06-01T13:00:00)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913570850
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143012/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-920549244
> but may not be that clear to human thought, which seems not a problem to me
The human being will code the query so the first class concern should be started from end users' view, not from machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-914131464
These special datetime strings are like functions and we should limit where they can be used. For this particular use case, I think the spark application is able to generate the timestamp string for yesterday/today/tomorrow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33908: [SPARK-36662][SQL] special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912397328
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47472/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912839065
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142987/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912352109
**[Test build #142971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142971/testReport)** for PR 33908 at commit [`dc1e0fe`](https://github.com/apache/spark/commit/dc1e0fe731be5ee5854083c92f0ffbfb4ceada65).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913377220
**[Test build #143012 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143012/testReport)** for PR 33908 at commit [`a3b7d08`](https://github.com/apache/spark/commit/a3b7d08983115c84225ce52f8db3dd16efd5471e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR edited a comment on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
HeartSaVioR edited a comment on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913438275
The confusion on time unit on second makes an error of "second". We don't care much about "millisecond" precision on the modified date in file, because we can't predict it while writing files. Please let me know if your use case needs to classify the millisecond precision on determining which files to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR edited a comment on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
HeartSaVioR edited a comment on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913438275
The confusion on time unit on second makes an error of "second". We don't care much about "millisecond" precision on the modified date in file, because we can't predict it. Please let me know if your use case needs to classify the millisecond precision on determining which files to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912690104
**[Test build #142987 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142987/testReport)** for PR 33908 at commit [`74c4aad`](https://github.com/apache/spark/commit/74c4aad34c445b774468f3f5f7aa3943b01b6c83).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912717209
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47488/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913561525
**[Test build #143012 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143012/testReport)** for PR 33908 at commit [`a3b7d08`](https://github.com/apache/spark/commit/a3b7d08983115c84225ce52f8db3dd16efd5471e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913401309
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47514/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912839065
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142987/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913410946
The current implementation also accepts timestamps in an incomplete form like, `2021-09`, `2021-09-30`.
We can replace these values with both sentences above, what happens to September or 30th, September 2021?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] advancedxy commented on a change in pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
advancedxy commented on a change in pull request #33908:
URL: https://github.com/apache/spark/pull/33908#discussion_r701914384
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/PathFilterSuite.scala
##########
@@ -222,6 +222,19 @@ class PathFilterSuite extends QueryTest with SharedSparkSession {
}
}
+ test("SPARK-36662: special timestamps support for path filters - modifiedBefore/modifiedAfter") {
+ withTempPath { path =>
+ val dataDir = path.getCanonicalPath
+ Seq("foo").toDS().write.text(dataDir)
+ val df = spark.read.option("modifiedbefore", "yesterday").text(dataDir)
+ assert(df.isEmpty)
+
+ // Both glob pattern in option and path should be effective to filter files.
+ val df2 = spark.read.option("modifiedbefore", "tomorrow").text(dataDir)
Review comment:
Since the title includes `modifiedBefore/modifiedAfter`, how about change it to `modifiedafter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33908: [SPARK-36662][SQL] special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912521200
**[Test build #142971 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142971/testReport)** for PR 33908 at commit [`dc1e0fe`](https://github.com/apache/spark/commit/dc1e0fe731be5ee5854083c92f0ffbfb4ceada65).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912530174
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142971/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913393690
I'm not sure these special notions are interpreted into "timestamp" in consistent way. No doubt they have clear semantics when they are used as "date", but I'm not very clear whether the "yesterday" should be interpreted to the yesterday "00:00:00".
Suppose two sentences:
* "Spark will read the files which are modified before yesterday."
* "Spark will read the files which are modified after yesterday."
How we interpret these sentences? Is the time point (in timestamp) of "yesterday" same for both sentences?
For me, all files modified in yesterday should be excluded in both sentences, but it won't be interpreted like that if we consider the semantic of "yesterday" as yesterday "00:00:00".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913406468
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47514/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913340750
hmmm I thought we already have this. cc @HyukjinKwon @HeartSaVioR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-913323027
cc @cloud-fan @MaxGekk thanks very much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33908: [SPARK-36662][SQL] special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912397287
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47472/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33908: [SPARK-36662][SQL] Special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912530174
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142971/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33908: [SPARK-36662][SQL] special timestamps support for path filters - modifiedBefore/modifiedAfter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33908:
URL: https://github.com/apache/spark/pull/33908#issuecomment-912397328
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47472/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org