You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "461911662 (via GitHub)" <gi...@apache.org> on 2026/03/19 13:31:40 UTC
[PR] arch/xtensa/esp32s3: Fix ROM strdup heap issue in USER_HEAP mode [nuttx]
461911662 opened a new pull request, #18563:
URL: https://github.com/apache/nuttx/pull/18563
In ESP32-S3 flat build with USER_HEAP mode, ROM strdup internally calls malloc which may be mapped to a different heap than lib_free, causing cross-heap allocation issues and system crashes.
This commit adds a new Kconfig option ESP32S3_DONT_USE_ROM_LIBC to allow using NuttX libc instead of ROM newlib functions. When USER_HEAP mode is selected, this option is automatically enabled.
Fixes: 60ca804b56 ("esp32s3: Fix bug related to the PSRAM-allocated task stack")
Reviewed-by: Tiago Medicci Serrano <ti...@espressif.com>
Reviewed-by: Almir Okato <al...@espressif.com>
Reviewed-by: Eren Terzioglu <er...@espressif.com>
*Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
## Summary
*Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.*
## Impact
*Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.*
## Testing
*This section should provide a detailed description of what you did
to verify your changes work and do not break existing code.*
*Please provide information about your host machine, the board(s) you
tested your changes on, and how you tested. Logs should be included.*
*For example, when changing something in the core OS functions, you
may want to run the OSTest application to verify that there are no
regressions. Changes to ADC code may warrant running the `adc`
example. Adding a new uORB driver may require that you run
`uorb_listener` to verify correct operation.*
*Pure documentation changes can just be tested with `make html`
(see docs) and verification of the correct format in your
browser.*
**_PRs without testing information will not be accepted. We will
request test logs._**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/xtensa/esp32s3: Fix ROM strdup heap issue in USER_HEAP mode [nuttx]
Posted by "461911662 (via GitHub)" <gi...@apache.org>.
461911662 commented on PR #18563:
URL: https://github.com/apache/nuttx/pull/18563#issuecomment-4091978493
这是来自QQ邮箱的假期自动回复邮件。你好，我最近正在休假中，无法亲自回复你的邮件。我将在假期结束后，尽快给你回复。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/xtensa/esp32s3: Fix ROM strdup heap issue in USER_HEAP mode [nuttx]
Posted by "461911662 (via GitHub)" <gi...@apache.org>.
461911662 commented on PR #18563:
URL: https://github.com/apache/nuttx/pull/18563#issuecomment-4243729278
这是来自QQ邮箱的假期自动回复邮件。你好，我最近正在休假中，无法亲自回复你的邮件。我将在假期结束后，尽快给你回复。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/xtensa/esp32s3: Fix ROM strdup heap issue in USER_HEAP mode [nuttx]
Posted by "cederom (via GitHub)" <gi...@apache.org>.
cederom commented on PR #18563:
URL: https://github.com/apache/nuttx/pull/18563#issuecomment-4094940455
> 这是来自QQ邮箱的假期自动回复邮件。你好，我最近正在休假中，无法亲自回复你的邮件。我将在假期结束后，尽快给你回复。
This is an automated holiday reply email from QQ Mail. Hello, I am currently on vacation and unable to reply to your email personally. I will reply to you as soon as possible after my vacation ends.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/xtensa/esp32s3: Fix ROM strdup heap issue in USER_HEAP mode [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #18563:
URL: https://github.com/apache/nuttx/pull/18563#issuecomment-4244621131
> > 这是来自QQ邮箱的假期自动回复邮件。你好，我最近正在休假中，无法亲自回复你的邮件。我将在假期结束后，尽快给你回复。
>
> This is an Open Source project that uses English language !
It is automatic email response, maybe he can remember to configure the email server to don't replay automatically for emails from github
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/xtensa/esp32s3: Fix ROM strdup heap issue in USER_HEAP mode [nuttx]
Posted by "jerpelea (via GitHub)" <gi...@apache.org>.
jerpelea commented on PR #18563:
URL: https://github.com/apache/nuttx/pull/18563#issuecomment-4243970033
> 这是来自QQ邮箱的假期自动回复邮件。你好，我最近正在休假中，无法亲自回复你的邮件。我将在假期结束后，尽快给你回复。
This is an Open Source project that uses English language !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/xtensa/esp32s3: Fix ROM strdup heap issue in USER_HEAP mode [nuttx]
Posted by "tmedicci (via GitHub)" <gi...@apache.org>.
tmedicci closed pull request #18563: arch/xtensa/esp32s3: Fix ROM strdup heap issue in USER_HEAP mode
URL: https://github.com/apache/nuttx/pull/18563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/xtensa/esp32s3: Fix ROM strdup heap issue in USER_HEAP mode [nuttx]
Posted by "eren-terzioglu (via GitHub)" <gi...@apache.org>.
eren-terzioglu commented on PR #18563:
URL: https://github.com/apache/nuttx/pull/18563#issuecomment-4096814885
Hi,
We were planning to use Nuttx implementation of `strdup` and `strndup` functions but disabling all the other functions might causes some issues. We need to check, please do not merge it.
Thanks for your work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/xtensa/esp32s3: Fix ROM strdup heap issue in USER_HEAP mode [nuttx]
Posted by "tmedicci (via GitHub)" <gi...@apache.org>.
tmedicci commented on PR #18563:
URL: https://github.com/apache/nuttx/pull/18563#issuecomment-4243725765
Closed because https://github.com/apache/nuttx/pull/18728 incorporates this change. Thanks @461911662!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org