You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/17 14:39:19 UTC

[GitHub] [airflow-ci-infra] ashb opened a new pull request #30: 🚧 Don't kill Runner.Listener when steps running

ashb opened a new pull request #30:
URL: https://github.com/apache/airflow-ci-infra/pull/30


   Because of the `--once` flag we already pass to the deamon, _if_ there
   were any jobs running, then the main actions-runner deamon (the
   Runner.Listener process) will shut it self down once it's _actually_
   finished.
   
   So we want to avoid the `pkill Runner.Listener` in the case when a step
   was executing, as otherwise we will likely kill the deamon before it has
   a chance to complete the job/report back to GitHub/run the next step.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-ci-infra] ashb commented on pull request #30: 🚧 Don't kill Runner.Listener when steps running

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #30:
URL: https://github.com/apache/airflow-ci-infra/pull/30#issuecomment-842380907


   We'll need to keep an eye on this -- if it _doesn't_ work then we'll have the instances not terminate in a timely fashion (they'll hit the timeout on AWS after 1 hour and then be hard-killed by AWS)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-ci-infra] ashb commented on pull request #30: Don't kill Runner.Listener when steps running

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #30:
URL: https://github.com/apache/airflow-ci-infra/pull/30#issuecomment-843018546


   Seems better.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-ci-infra] ashb merged pull request #30: Don't kill Runner.Listener when steps running

Posted by GitBox <gi...@apache.org>.
ashb merged pull request #30:
URL: https://github.com/apache/airflow-ci-infra/pull/30


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-ci-infra] ashb commented on pull request #30: 🚧 Don't kill Runner.Listener when steps running

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #30:
URL: https://github.com/apache/airflow-ci-infra/pull/30#issuecomment-842380907


   We'll need to keep an eye on this -- if it _doesn't_ work then we'll have the instances not terminate in a timely fashion (they'll hit the timeout on AWS after 1 hour and then be hard-killed by AWS)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org