You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/28 10:53:48 UTC

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7028: add index to speed up querying IPs in the network-tab

weizhouapache commented on code in PR #7028:
URL: https://github.com/apache/cloudstack/pull/7028#discussion_r1058260298


##########
engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql:
##########
@@ -869,3 +869,6 @@ WHERE   usage_unit = 'Policy-Month';
 
 -- delete configuration task.cleanup.retry.interval #6910
 DELETE FROM `cloud`.`configuration` WHERE name='task.cleanup.retry.interval';
+
+--- #6888 add index to speed up querying IPs in the network-tab
+ALTER TABLE `user_ip_address` ADD KEY `fk_user_ip_address__state` (`state`);

Review Comment:
   @DaanHoogland 
   `state` is not a foreign key.
   It would be good to use `i_user_ip_address__state`
   
   might be better to create a procedure similar as IDEMPOTENT_ADD_FOREIGN_KEY ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org