You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/01/22 19:34:11 UTC
[GitHub] [maven] rosti-il opened a new pull request #319: (doc) Simplify code
rosti-il opened a new pull request #319: (doc) Simplify code
URL: https://github.com/apache/maven/pull/319
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] rosti-il commented on issue #319: (doc) Simplify code
Posted by GitBox <gi...@apache.org>.
rosti-il commented on issue #319: (doc) Simplify code
URL: https://github.com/apache/maven/pull/319#issuecomment-578427153
@namannigam I've run the Core IT successfully. Checked that checkbox above.
Should I create a Jira issue? This PR is a collection of small changes, this is why commits of each of them are prefixed by "(doc)".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] slachiewicz commented on issue #319: (doc) Simplify code
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on issue #319: (doc) Simplify code
URL: https://github.com/apache/maven/pull/319#issuecomment-578503777
we are open for code improvements but please keep a balance between functional interfaces and more required bug fixing - we have more than 1000 different existing issues to address. A good place to learn more about Maven internals and help other people.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] namannigam commented on issue #319: (doc) Simplify code
Posted by GitBox <gi...@apache.org>.
namannigam commented on issue #319: (doc) Simplify code
URL: https://github.com/apache/maven/pull/319#issuecomment-578497581
@slachiewicz Would the syntax migration be open to moving onto concepts like `Stream` and `FunctionalInterface`s as well (functional programming paradigm)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] asfgit closed pull request #319: (doc) Simplify code
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #319: (doc) Simplify code
URL: https://github.com/apache/maven/pull/319
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] slachiewicz commented on issue #319: (doc) Simplify code
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on issue #319: (doc) Simplify code
URL: https://github.com/apache/maven/pull/319#issuecomment-578491120
thx @rosti-il for code improvements. I've created [MNG-6855](https://issues.apache.org/jira/browse/MNG-6855) to group misc code improvements. Feel free to add more :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] rfscholte commented on issue #319: (doc) Simplify code
Posted by GitBox <gi...@apache.org>.
rfscholte commented on issue #319: (doc) Simplify code
URL: https://github.com/apache/maven/pull/319#issuecomment-578432261
See https://maven.apache.org/developers/conventions/jira.html so IMO no JIRA required
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services