You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/28 21:12:45 UTC

[GitHub] [incubator-nuttx] onegray commented on a diff in pull request #6174: stm32l4 minor fixes

onegray commented on code in PR #6174:
URL: https://github.com/apache/incubator-nuttx/pull/6174#discussion_r861314386


##########
arch/arm/src/stm32l4/stm32l4xrxx_rcc.c:
##########
@@ -789,15 +785,6 @@ static void stm32l4_stdclockconfig(void)
       regval |= STM32L4_RCC_CFGR_PPRE1;
       putreg32(regval, STM32L4_RCC_CFGR);
 
-#ifdef CONFIG_STM32L4_RTC_HSECLOCK

Review Comment:
   This option still needed to select RTC clock source.  The lines are proposed to delete because L4 does not have RTCPRE register.  The HSE source prescaler is fixed to HSE/32.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org