svn commit: r1866039 - /jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java

[re...@apache.org]

Author: reschke
Date: Wed Aug 28 13:59:57 2019
New Revision: 1866039

URL: http://svn.apache.org/viewvc?rev=1866039&view=rev
Log:
OAK-8583: getNodeByIdentifier may fail with RuntimeException - add tests, one of which currently ignored

Modified:
    jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java

Modified: jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java?rev=1866039&r1=1866038&r2=1866039&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java (original)
+++ jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java Wed Aug 28 13:59:57 2019
@@ -50,6 +50,7 @@ import javax.jcr.GuestCredentials;
 import javax.jcr.InvalidItemStateException;
 import javax.jcr.Item;
 import javax.jcr.ItemExistsException;
+import javax.jcr.ItemNotFoundException;
 import javax.jcr.NamespaceException;
 import javax.jcr.NamespaceRegistry;
 import javax.jcr.NoSuchWorkspaceException;
@@ -376,6 +377,27 @@ public class RepositoryTest extends Abst
     }
 
     @Test
+    public void getNodeByIncorrectIdentifier() throws RepositoryException {
+        Node node = getNode("/foo");
+        String id = node.getIdentifier() + "foofoofoo";
+        try {
+            getAdminSession().getNodeByIdentifier(id);
+            fail("should not get here");
+        } catch (ItemNotFoundException expected) {
+        }
+    }
+
+    @Ignore
+    @Test
+    public void getNodeByEmptyIdentifier() throws RepositoryException {
+        try {
+            getAdminSession().getNodeByIdentifier("");
+            fail("should not get here");
+        } catch (RepositoryException expected) {
+        }
+    }
+
+    @Test
     public void getNodeByUUID() throws RepositoryException {
         Node node = getNode("/foo").addNode("boo");
         node.addMixin(JcrConstants.MIX_REFERENCEABLE);