[GitHub] [flink] twalthr commented on a change in pull request #11253: [FLINK-16336][table] Add new type inference for temporal table functions

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#discussion_r392171630
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/logical/FlinkLogicalTableFunctionScan.scala
 ##########
 @@ -96,11 +96,12 @@ class FlinkLogicalTableFunctionScanConverter
       return false
     }
     val rexCall = logicalTableFunction.getCall.asInstanceOf[RexCall]
-    if (!rexCall.getOperator.isInstanceOf[TableSqlFunction]) {
-      return false
+    val functionDefinition = rexCall.getOperator match {
+      case tsf: TableSqlFunction => tsf.udtf
+      case bsf: BridgingSqlFunction => bsf.getDefinition
 
 Review comment:
   In the catalog layer, see `FunctionCatalogOperatorTable`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services