[GitHub] [flink] Myasuka commented on issue #9268: [FLINK-13452] Ensure to fail global when exception happens during reseting tasks of regions

[GitBox <gi...@apache.org>]

Myasuka commented on issue #9268: [FLINK-13452] Ensure to fail global when exception happens during reseting tasks of regions
URL: https://github.com/apache/flink/pull/9268#issuecomment-517591673
 
 
   @GJL new commit content is updated in description.
   
   There is another question which might be out of the scope of this PR but confused me. If I set the failure times of `FailureMultiTimesRestartStrategy` as 2, which means the restartStrategy would failed twice when calling restart. During `AdaptedRestartPipelinedRegionStrategyNG#restartTasks`, job would first meet exception when `restartStrategy.restart` and then call `failGlobalOnError`. However, in the call stack of `ExecutionGraph#failGlobal` --> `ExecutionGraph#allVerticesInTerminalState` --> `ExecutionGraph#tryRestartOrFail` --> `restartStrategy.restart`, we would meet the 2nd exception and caught by `FatalExitExceptionHandler`, resulting in the process exited. 
   
   In other words, if we meet unchecked exception during `ExecutionGraph#failGlobal`, we would just let the whole process exit instead of trying to fail global again. Is this behavior expected?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services