You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by "EdgarRamirezFuentes (via GitHub)" <gi...@apache.org> on 2023/07/17 06:50:01 UTC
[GitHub] [shiro] EdgarRamirezFuentes opened a new pull request, #1012: [#1005] Move checkstyle to root pom.xml
EdgarRamirezFuentes opened a new pull request, #1012:
URL: https://github.com/apache/shiro/pull/1012
Move the checkstyle plugin from integration-tests/jakarta-ee [shiro-its-jakarta-ee]/pom.xml to the root pom.xml
When running the command `mvn verify` to make the basic checks run, it fails when it starts audit in `org.apache.shiro:shiro-lang`.
<details>
<summary>Audit result</summary>
</details>
<details>
<summary>Some audit errors</summary>
</details>
<details>
<summary>Build failure</summary>
</details>
<!--
For Security Vulnerabilities, please email: security@shiro.apache.org
For more details on how to report a vulnerablity see: https://www.apache.org/security/
-->
Following this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GitHub issue](https://github.com/apache/shiro/issues) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[#XXX] - Fixes bug in SessionManager`,
where you replace `#XXX` with the appropriate GitHub issue. Best practice
is to use the GitHub issue title in the pull request title and in the first line of the commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] add `fixes #XXX` if merging the PR should close a related issue.
- [x] Run `mvn verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
- [ ] Committers: Make sure a milestone is set on the PR
Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like `[DOC] - Add javadoc in SessionManager`.
If this is your first contribution, you have to read the [Contribution Guidelines](https://github.com/apache/shiro/blob/master/CONTRIBUTING.md)
If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1005] Move checkstyle to root pom.xml [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1012:
URL: https://github.com/apache/shiro/pull/1012#issuecomment-1745848514
Superseded by #1069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1005] Move checkstyle to root pom.xml [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak closed pull request #1012: [#1005] Move checkstyle to root pom.xml
URL: https://github.com/apache/shiro/pull/1012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] lprimak commented on pull request #1012: [#1005] Move checkstyle to root pom.xml
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1012:
URL: https://github.com/apache/shiro/pull/1012#issuecomment-1638375572
Couple of comments:
* Can you please make your PR draft until it's ready?
Here is the order of preference / priority for type of checkstyle-related fixes:
* Fix the code itself to conform to checkstyle
* Use `@SuppressWarnings` to ignore error
* Add a line to suppressions.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] lprimak commented on pull request #1012: [#1005] Move checkstyle to root pom.xml
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1012:
URL: https://github.com/apache/shiro/pull/1012#issuecomment-1638379683
I would say for MagicNumber, `@SuppressWarnings` is the right thing to do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org