You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Yuming Wang (JIRA)" <ji...@apache.org> on 2019/03/06 16:50:00 UTC
[jira] [Updated] (SPARK-27074) Refactor HiveClientImpl runHive
[ https://issues.apache.org/jira/browse/SPARK-27074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yuming Wang updated SPARK-27074:
--------------------------------
Description:
Hive 3.1.1's {{CommandProcessor}} have 2 changes:
# HIVE-17626(Hive 3.0.0) add ReExecDriver. So the current code path is:
[spark/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala|https://github.com/apache/spark/blob/02bbe977abaf7006b845a7e99d612b0235aa0025/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala#L736-L742]
Lines 736 to 742 in [02bbe97|https://github.com/apache/spark/commit/02bbe977abaf7006b845a7e99d612b0235aa0025]
| |case _ =>|
| |if (state.out != null) {|
| |// scalastyle:off println|
| |state.out.println(tokens(0) + " " + cmd_1)|
| |// scalastyle:on println|
| |}|
| |Seq(proc.run(cmd_1).getResponseCode.toString)|
This is incorrect.
# [HIVE-18238|http://issues.apache.org/jira/browse/HIVE-18238](Hive 3.0.0) changed the {{Driver.close()}} function return type. This change is not compatible with the built-in Hive.
> Refactor HiveClientImpl runHive
> -------------------------------
>
> Key: SPARK-27074
> URL: https://issues.apache.org/jira/browse/SPARK-27074
> Project: Spark
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 3.0.0
> Reporter: Yuming Wang
> Priority: Major
>
> Hive 3.1.1's {{CommandProcessor}} have 2 changes:
> # HIVE-17626(Hive 3.0.0) add ReExecDriver. So the current code path is:
> [spark/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala|https://github.com/apache/spark/blob/02bbe977abaf7006b845a7e99d612b0235aa0025/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala#L736-L742]
> Lines 736 to 742 in [02bbe97|https://github.com/apache/spark/commit/02bbe977abaf7006b845a7e99d612b0235aa0025]
> | |case _ =>|
> | |if (state.out != null) {|
> | |// scalastyle:off println|
> | |state.out.println(tokens(0) + " " + cmd_1)|
> | |// scalastyle:on println|
> | |}|
> | |Seq(proc.run(cmd_1).getResponseCode.toString)|
> This is incorrect.
> # [HIVE-18238|http://issues.apache.org/jira/browse/HIVE-18238](Hive 3.0.0) changed the {{Driver.close()}} function return type. This change is not compatible with the built-in Hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org