You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "nadment (via GitHub)" <gi...@apache.org> on 2023/05/24 20:54:33 UTC
[GitHub] [hop] nadment opened a new pull request, #2963: Cleanup XML of action Set Variables #1989
nadment opened a new pull request, #2963:
URL: https://github.com/apache/hop/pull/2963
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] nadment commented on pull request #2963: Cleanup XML of action Set Variables #1989
Posted by "nadment (via GitHub)" <gi...@apache.org>.
nadment commented on PR #2963:
URL: https://github.com/apache/hop/pull/2963#issuecomment-1565454539
All credit goes to @mattcasters, I just copied a serialization test he did, much simpler than the old tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #2963: Cleanup XML of action Set Variables #1989
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on PR #2963:
URL: https://github.com/apache/hop/pull/2963#issuecomment-1565451140
awesome work @nadment, I'm loving these tests you are adding! we should expand that to all actions and transforms to validate the xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva merged pull request #2963: Cleanup XML of action Set Variables #1989
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva merged PR #2963:
URL: https://github.com/apache/hop/pull/2963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org