You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/03 18:08:35 UTC

[GitHub] [arrow] jorgecarleitao edited a comment on pull request #9404: ARROW-11482: [Rust] improve take kernel performance of PrimitiveArray

jorgecarleitao edited a comment on pull request #9404:
URL: https://github.com/apache/arrow/pull/9404#issuecomment-772710405


   in my experiments leading to #9301 I found no significant perf different between both variants and so did not consider an `unsafe` version, I admit that since the PR already offered a -30%, I also did not bother much ^_^
   
   once all our implementations are `sound`, IMO we should get rid of the take options and potentially offer an `unsafe` version like you said. What imo is not cool is having an implementation whose safety depends on a parameter. :P


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org