You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/05/01 07:36:30 UTC

[GitHub] [arrow] kou commented on a diff in pull request #35376: GH-35375: [C++][FlightRPC] Add `arrow::flight::ServerCallContext::incoming_headers()`

kou commented on code in PR #35376:
URL: https://github.com/apache/arrow/pull/35376#discussion_r1181441200


##########
cpp/src/arrow/flight/test_util.cc:
##########
@@ -474,12 +474,31 @@ class FlightTestServer : public FlightServerBase {
     return Status::OK();
   }
 
+  Status ListIncomingHeaders(const ServerCallContext& context, const Action& action,
+                             std::unique_ptr<ResultStream>* out) {
+    std::vector<Result> results;
+    auto prefix = static_cast<std::string_view>(*(action.body));

Review Comment:
   OK. How about `std::string_view prefix(*action.body)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org