You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/19 23:22:41 UTC

[GitHub] venkata91 commented on a change in pull request #23803: [SPARK-26894][SQL] Handle Alias as well in AggregateEstimation to propagate child stats

venkata91 commented on a change in pull request #23803: [SPARK-26894][SQL] Handle Alias as well in AggregateEstimation to propagate child stats
URL: https://github.com/apache/spark/pull/23803#discussion_r258273880
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/AggregateEstimation.scala
 ##########
 @@ -52,7 +52,13 @@ object AggregateEstimation {
         outputRows.min(childStats.rowCount.get)
       }
 
-      val outputAttrStats = getOutputMap(childStats.attributeStats, agg.output)
+      val inputAttrStats = childStats.attributeStats
 
 Review comment:
   Done. Also added unit test case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org