You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Aleksandr Kovalenko <ak...@hortonworks.com> on 2017/02/21 16:06:58 UTC
Review Request 56893: Configs filter is not reset if configs has no
filter input
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56893/
-----------------------------------------------------------
Review request for Ambari and Andriy Babiichuk.
Bugs: AMBARI-20100
https://issues.apache.org/jira/browse/AMBARI-20100
Repository: ambari
Description
-------
STR:
1. Open Add Service Wizard.
2. Proceed to the Customize Services step.
3. Input some value in configs filter.
4. Switch tab to Misc configs.
Expected result: all configs are shown.
Actual result: configs are filtered, it is unable to clear filter.
Diffs
-----
ambari-web/app/views/common/configs/service_config_view.js daf26b0
Diff: https://reviews.apache.org/r/56893/diff/
Testing
-------
20376 passing (35s)
153 pending
Thanks,
Aleksandr Kovalenko
Re: Review Request 56893: Configs filter is not reset if configs has
no filter input
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56893/#review166180
-----------------------------------------------------------
Ship it!
Ship It!
- Andriy Babiichuk
On \u041b\u044e\u0442. 21, 2017, 4:06 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Aleksandr Kovalenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56893/
> -----------------------------------------------------------
>
> (Updated \u041b\u044e\u0442. 21, 2017, 4:06 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
>
>
> Review request for Ambari and Andriy Babiichuk.
>
>
> Bugs: AMBARI-20100
> https://issues.apache.org/jira/browse/AMBARI-20100
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> 1. Open Add Service Wizard.
> 2. Proceed to the Customize Services step.
> 3. Input some value in configs filter.
> 4. Switch tab to Misc configs.
> Expected result: all configs are shown.
> Actual result: configs are filtered, it is unable to clear filter.
>
>
> Diffs
> -----
>
> ambari-web/app/views/common/configs/service_config_view.js daf26b0
>
> Diff: https://reviews.apache.org/r/56893/diff/
>
>
> Testing
> -------
>
> 20376 passing (35s)
> 153 pending
>
>
> Thanks,
>
> Aleksandr Kovalenko
>
>