You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by sdutry <gi...@git.apache.org> on 2017/08/01 15:50:19 UTC
[GitHub] struts pull request #156: WW-4834 Improve RegEx used to validate URLs
GitHub user sdutry opened a pull request:
https://github.com/apache/struts/pull/156
WW-4834 Improve RegEx used to validate URLs
changed the regex according to https://github.com/apache/struts/commit/8df5a897f61f3ef45c36fdd9275e66669ae4516c#commitcomment-23414493
Can anyone tell me if the optional `#` on line 54 is needed?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sdutry/struts WW-4834
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/struts/pull/156.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #156
----
commit 9d47af6ffa355977b5acc713e6d1f25fac260a28
Author: Stefaan Dutry <st...@gmail.com>
Date: 2017-08-01T15:33:53Z
WW-4834 Improve RegEx used to validate URLs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request #156: WW-4834 Improve RegEx used to validate URLs
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/struts/pull/156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts issue #156: WW-4834 Improve RegEx used to validate URLs
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/156
Ach... you did merge it :\ But this isn't a valid RegEx :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org