You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/10 01:00:58 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #8799: Update
sql validator status
codecov-io commented on issue #8799: Update sql validator status
URL: https://github.com/apache/incubator-superset/pull/8799#issuecomment-563511372
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8799?src=pr&el=h1) Report
> Merging [#8799](https://codecov.io/gh/apache/incubator-superset/pull/8799?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8a00168b63f21738f58854f026892572d3ef1fd7?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8799?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8799 +/- ##
=========================================
+ Coverage 65.85% 65.9% +0.04%
=========================================
Files 482 482
Lines 24152 24162 +10
Branches 2770 2770
=========================================
+ Hits 15906 15924 +18
+ Misses 8068 8060 -8
Partials 178 178
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8799?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/presto\_db.py](https://codecov.io/gh/apache/incubator-superset/pull/8799/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcHJlc3RvX2RiLnB5) | `82.43% <50%> (-2.08%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8799/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.13% <66.66%> (+0.27%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8799/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `74.74% <0%> (ø)` | :arrow_up: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8799/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `91.89% <0%> (+0.9%)` | :arrow_up: |
| [superset/extensions.py](https://codecov.io/gh/apache/incubator-superset/pull/8799/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `96.15% <0%> (+1.28%)` | :arrow_up: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8799/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `60.52% <0%> (+3.94%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8799?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8799?src=pr&el=footer). Last update [8a00168...133a799](https://codecov.io/gh/apache/incubator-superset/pull/8799?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org