You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "XHL-study (via GitHub)" <gi...@apache.org> on 2024/12/23 13:00:18 UTC
[PR] Fixed the problem that the rich style does not take effect when tooltip is in renderMode=richText [echarts]
XHL-study opened a new pull request, #20615:
URL: https://github.com/apache/echarts/pull/20615
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
Fixed the problem that the rich style does not take effect when tooltip is in renderMode=richText
### Fixed issues
<!--
- #xxxx: ...
-->
#19966
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
In previous versions, rich style did not work when using tooltip attribute renderMode=richText
### After: How does it behave after the fixing?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
Now, when using the tooltip attribute renderMode=richText, the rich style will achieve the expected effect, as shown below:
## Document Info
One of the following should be checked.
- [ ] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] Fixed the problem that the rich style does not take effect when tooltip is in renderMode=richText [echarts]
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #20615:
URL: https://github.com/apache/echarts/pull/20615#issuecomment-2559711268
Document changes are required in this PR. Please also make a PR to [apache/echarts-doc](https://github.com/apache/echarts-doc) for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] Fixed the problem that the rich style does not take effect when tooltip is in renderMode=richText [echarts]
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #20615:
URL: https://github.com/apache/echarts/pull/20615#issuecomment-2559667111
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] Fixed the problem that the rich style does not take effect when tooltip is in renderMode=richText [echarts]
Posted by "XHL-study (via GitHub)" <gi...@apache.org>.
XHL-study closed pull request #20615: Fixed the problem that the rich style does not take effect when tooltip is in renderMode=richText
URL: https://github.com/apache/echarts/pull/20615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] Fixed the problem that the rich style does not take effect when tooltip is in renderMode=richText [echarts]
Posted by "XHL-study (via GitHub)" <gi...@apache.org>.
XHL-study commented on PR #20615:
URL: https://github.com/apache/echarts/pull/20615#issuecomment-2562103258
> Please don't commit the changes under `dist`.
I have modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] Fixed the problem that the rich style does not take effect when tooltip is in renderMode=richText [echarts]
Posted by "XHL-study (via GitHub)" <gi...@apache.org>.
XHL-study commented on PR #20615:
URL: https://github.com/apache/echarts/pull/20615#issuecomment-2562402891
> This is not the way to support rich text. Consider checking out how `title.textStyle` does. And there is no good reason here using `ts-ignore` to ignore the typing problems.
>
> This should be a new feature instead of a bug fixing because there isn't doc for `rich` now and you need to check "The document should be updated later".
>
> Also, you should include test cases as according to [the wiki](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request#test).
我需要重新提交一个feat吗。。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org