You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by ma...@apache.org on 2026/01/19 16:54:31 UTC
(incubator-gluten) branch main updated: [GLUTEN-6887][VL] Daily Update Velox Version (2026_01_19) (#11443)
This is an automated email from the ASF dual-hosted git repository.
marong pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 6782c5857e [GLUTEN-6887][VL] Daily Update Velox Version (2026_01_19) (#11443)
6782c5857e is described below
commit 6782c5857e4a9abc3a962c7bd935847ed6804780
Author: Gluten Performance Bot <13...@users.noreply.github.com>
AuthorDate: Mon Jan 19 16:54:26 2026 +0000
[GLUTEN-6887][VL] Daily Update Velox Version (2026_01_19) (#11443)
* [GLUTEN-6887][VL] Daily Update Velox Version (dft-2026_01_19)
Upstream Velox's New Commits:
98dd37935 by Xiaoxuan Meng, feat: Add sortOrders() getter to KeyEncoder (#16057)
9380556ee by Henry Edwin Dikeman, feat(connector): Add TPCH connector serdes (#16033)
229b01564 by Xiaoxuan Meng, refactor: Trivial distinct aggregation cleanup (#16054)
725110245 by Xiaoxuan Meng, refactor: Deprecate the old cleanup aggregation node ctor APIs (#16053)
5a2aad8f7 by Bikramjeet Vig, feat: Add owner metadata field to Velox functions for error attribution (#15788)
9f9843250 by Eric Jia, refactor: Replace as<> with asChecked<> in IcebergDataSink (#16035)
3ad5164d9 by Pedro Eugenio Rocha Pedreira, refactor(python): Simplify task iterator API (#15943)
80e6c4ba4 by Masha Basmanova, fix: TypeCoercer::leastCommonSuperType for named structs (#16038)
Signed-off-by: glutenperfbot <gl...@glutenproject-internal.com>
---------
Signed-off-by: glutenperfbot <gl...@glutenproject-internal.com>
Co-authored-by: glutenperfbot <gl...@glutenproject-internal.com>
Co-authored-by: Rong Ma <ma...@apache.org>
---
cpp/velox/substrait/SubstraitToVeloxPlan.cc | 19 +++++++++++--------
ep/build-velox/src/get-velox.sh | 4 ++--
2 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/cpp/velox/substrait/SubstraitToVeloxPlan.cc b/cpp/velox/substrait/SubstraitToVeloxPlan.cc
index 1b1ee1f493..b20b4a3d09 100644
--- a/cpp/velox/substrait/SubstraitToVeloxPlan.cc
+++ b/cpp/velox/substrait/SubstraitToVeloxPlan.cc
@@ -464,7 +464,7 @@ core::PlanNodePtr SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
// Get the grouping expressions.
VELOX_CHECK(
- aggRel.groupings().size() <= 1, "At most one grouping is supported, but got {}.", aggRel.groupings().size());
+ aggRel.groupings().size() <= 1, "At most one grouping is supported, but got {}.", aggRel.groupings().size());
if (aggRel.groupings().size() == 1) {
for (const auto& groupingExpr : aggRel.groupings()[0].grouping_expressions()) {
// Velox's groupings are limited to be Field.
@@ -504,7 +504,6 @@ core::PlanNodePtr SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
aggregates.emplace_back(core::AggregationNode::Aggregate{aggExpr, rawInputTypes, mask, {}, {}});
}
- bool ignoreNullKeys = false;
std::vector<core::FieldAccessTypedExprPtr> preGroupingExprs;
if (aggRel.has_advanced_extension() &&
SubstraitParser::configSetInOptimization(aggRel.advanced_extension(), "isStreaming=")) {
@@ -526,7 +525,8 @@ core::PlanNodePtr SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
preGroupingExprs,
aggOutNames,
aggregates,
- ignoreNullKeys,
+ /*ignoreNullKeys=*/false,
+ /*noGroupsSpanBatches=*/false,
childNode);
if (aggRel.has_common()) {
@@ -904,10 +904,9 @@ core::PlanNodePtr SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
(std::dynamic_pointer_cast<const core::ProjectNode>(childNode) != nullptr ||
std::dynamic_pointer_cast<const ValueStreamNode>(childNode) != nullptr)
#ifdef GLUTEN_ENABLE_GPU
- || std::dynamic_pointer_cast<const CudfValueStreamNode>(childNode) != nullptr
+ || std::dynamic_pointer_cast<const CudfValueStreamNode>(childNode) != nullptr
#endif
- &&
- childNode->outputType()->size() > requiredChildOutput.size(),
+ && childNode->outputType()->size() > requiredChildOutput.size(),
"injectedProject is true, but the ProjectNode or ValueStreamNode (in case of projection fallback)"
" is missing or does not have the corresponding projection field");
@@ -1653,9 +1652,13 @@ bool SubstraitToVeloxPlanConverter::checkTypeExtension(const ::substrait::Plan&
}
#ifdef GLUTEN_ENABLE_GPU
-template core::PlanNodePtr SubstraitToVeloxPlanConverter::constructValueStreamNode<CudfValueStreamNode>(const ::substrait::ReadRel& sRead, int32_t streamIdx);
+template core::PlanNodePtr SubstraitToVeloxPlanConverter::constructValueStreamNode<CudfValueStreamNode>(
+ const ::substrait::ReadRel& sRead,
+ int32_t streamIdx);
#endif
-template core::PlanNodePtr SubstraitToVeloxPlanConverter::constructValueStreamNode<ValueStreamNode>(const ::substrait::ReadRel& sRead, int32_t streamIdx);
+template core::PlanNodePtr SubstraitToVeloxPlanConverter::constructValueStreamNode<ValueStreamNode>(
+ const ::substrait::ReadRel& sRead,
+ int32_t streamIdx);
} // namespace gluten
diff --git a/ep/build-velox/src/get-velox.sh b/ep/build-velox/src/get-velox.sh
index 14070294bd..1f5eaa7ee4 100755
--- a/ep/build-velox/src/get-velox.sh
+++ b/ep/build-velox/src/get-velox.sh
@@ -18,8 +18,8 @@ set -exu
CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd)
VELOX_REPO=https://github.com/IBM/velox.git
-VELOX_BRANCH=dft-2026_01_16
-VELOX_ENHANCED_BRANCH=ibm-2026_01_16
+VELOX_BRANCH=dft-2026_01_19
+VELOX_ENHANCED_BRANCH=ibm-2026_01_19
VELOX_HOME=""
RUN_SETUP_SCRIPT=ON
ENABLE_ENHANCED_FEATURES=OFF
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org