[GitHub] [kafka] showuon commented on a diff in pull request #12882: fixbug: if period==0 , it should be an execution thread rather than a…

[GitBox <gi...@apache.org>]

showuon commented on code in PR #12882:
URL: https://github.com/apache/kafka/pull/12882#discussion_r1027582167


##########
core/src/main/scala/kafka/utils/KafkaScheduler.scala:
##########
@@ -120,7 +120,8 @@ class KafkaScheduler(val threads: Int,
             trace("Completed execution of scheduled task '%s'.".format(name))
           }
         }
-        if (period >= 0)
+        //fixbug: if period==0 , it should be an execution thread rather than a throw error
+        if (period > 0)

Review Comment:
   Nice catch! Please remove the comment, and add a test in `SchedulerTest` for it. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org