You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/02/19 19:22:58 UTC
[GitHub] [maven-resolver] cstamas opened a new pull request #153: Update dependencies
cstamas opened a new pull request #153:
URL: https://github.com/apache/maven-resolver/pull/153
And make demo share maven, not define it twice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a change in pull request #153: Update dependencies
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #153:
URL: https://github.com/apache/maven-resolver/pull/153#discussion_r810534644
##########
File path: maven-resolver-named-locks-hazelcast/pom.xml
##########
@@ -52,7 +52,7 @@
<dependency>
<groupId>com.hazelcast</groupId>
<artifactId>hazelcast</artifactId>
- <version>4.1.2</version>
+ <version>5.0.1</version>
Review comment:
Did you test that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a change in pull request #153: [MRESOLVER-239] Update dependencies
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #153:
URL: https://github.com/apache/maven-resolver/pull/153#discussion_r810665814
##########
File path: pom.xml
##########
@@ -77,7 +77,7 @@
<guiceVersion>4.2.3</guiceVersion>
<guavaVersion>30.1-jre</guavaVersion>
<guavafailureaccessVersion>1.0.1</guavafailureaccessVersion>
- <slf4jVersion>1.7.32</slf4jVersion>
+ <slf4jVersion>1.7.36</slf4jVersion>
Review comment:
No hard requirement, just consistency reasons. That's it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a change in pull request #153: Update dependencies
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #153:
URL: https://github.com/apache/maven-resolver/pull/153#discussion_r810534662
##########
File path: pom.xml
##########
@@ -77,7 +77,7 @@
<guiceVersion>4.2.3</guiceVersion>
<guavaVersion>30.1-jre</guavaVersion>
<guavafailureaccessVersion>1.0.1</guavafailureaccessVersion>
- <slf4jVersion>1.7.32</slf4jVersion>
+ <slf4jVersion>1.7.36</slf4jVersion>
Review comment:
Should match MAven Core as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #153: Update dependencies
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #153:
URL: https://github.com/apache/maven-resolver/pull/153#discussion_r810530034
##########
File path: maven-resolver-named-locks-redisson/pom.xml
##########
@@ -52,7 +52,7 @@
<dependency>
<groupId>org.redisson</groupId>
<artifactId>redisson</artifactId>
- <version>3.15.6</version>
+ <version>3.16.8</version>
Review comment:
Rolled back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #153: Update dependencies
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #153:
URL: https://github.com/apache/maven-resolver/pull/153#discussion_r810529947
##########
File path: maven-resolver-transport-wagon/pom.xml
##########
@@ -56,7 +56,7 @@
<dependency>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-provider-api</artifactId>
- <version>3.4.3</version>
+ <version>3.5.1</version>
Review comment:
Um, it is, isn't it?
https://github.com/apache/maven/blob/master/pom.xml#L63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas merged pull request #153: [MRESOLVER-239] Update dependencies
Posted by GitBox <gi...@apache.org>.
cstamas merged pull request #153:
URL: https://github.com/apache/maven-resolver/pull/153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a change in pull request #153: Update dependencies
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #153:
URL: https://github.com/apache/maven-resolver/pull/153#discussion_r810535768
##########
File path: maven-resolver-named-locks-hazelcast/pom.xml
##########
@@ -52,7 +52,7 @@
<dependency>
<groupId>com.hazelcast</groupId>
<artifactId>hazelcast</artifactId>
- <version>4.1.2</version>
+ <version>5.0.1</version>
Review comment:
Hope this will work in prod also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #153: Update dependencies
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #153:
URL: https://github.com/apache/maven-resolver/pull/153#discussion_r810536042
##########
File path: maven-resolver-named-locks-hazelcast/pom.xml
##########
@@ -52,7 +52,7 @@
<dependency>
<groupId>com.hazelcast</groupId>
<artifactId>hazelcast</artifactId>
- <version>4.1.2</version>
+ <version>5.0.1</version>
Review comment:
Also, recently Proximity got updated to HZ 5.x from 4.x, and it is okay, trust me :wink:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #153: Update dependencies
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #153:
URL: https://github.com/apache/maven-resolver/pull/153#discussion_r810535266
##########
File path: maven-resolver-named-locks-hazelcast/pom.xml
##########
@@ -52,7 +52,7 @@
<dependency>
<groupId>com.hazelcast</groupId>
<artifactId>hazelcast</artifactId>
- <version>4.1.2</version>
+ <version>5.0.1</version>
Review comment:
Um, there are ITs, so yes:
```
[INFO] --- maven-failsafe-plugin:3.0.0-M5:integration-test (default) @ maven-resolver-named-locks-hazelcast ---
[INFO]
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.eclipse.aether.named.hazelcast.HazelcastClientCPSemaphoreAdapterIT
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 88.664 s - in org.eclipse.aether.named.hazelcast.HazelcastClientCPSemaphoreAdapterIT
[INFO] Running org.eclipse.aether.named.hazelcast.HazelcastCPSemaphoreAdapterIT
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.415 s - in org.eclipse.aether.named.hazelcast.HazelcastCPSemaphoreAdapterIT
[INFO] Running org.eclipse.aether.named.hazelcast.HazelcastCPSemaphoreNamedLockFactoryIT
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.119 s - in org.eclipse.aether.named.hazelcast.HazelcastCPSemaphoreNamedLockFactoryIT
[INFO] Running org.eclipse.aether.named.hazelcast.HazelcastClientCPSemaphoreNamedLockFactoryIT
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.995 s - in org.eclipse.aether.named.hazelcast.HazelcastClientCPSemaphoreNamedLockFactoryIT
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 36, Failures: 0, Errors: 0, Skipped: 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a change in pull request #153: Update dependencies
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #153:
URL: https://github.com/apache/maven-resolver/pull/153#discussion_r810528738
##########
File path: maven-resolver-transport-wagon/pom.xml
##########
@@ -56,7 +56,7 @@
<dependency>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-provider-api</artifactId>
- <version>3.4.3</version>
+ <version>3.5.1</version>
Review comment:
This should be consistent with Maven master.
##########
File path: maven-resolver-named-locks-redisson/pom.xml
##########
@@ -52,7 +52,7 @@
<dependency>
<groupId>org.redisson</groupId>
<artifactId>redisson</artifactId>
- <version>3.15.6</version>
+ <version>3.16.8</version>
Review comment:
This needs testing and update on docs since it lists trans deps, drop this for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #153: [MRESOLVER-239] Update dependencies
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #153:
URL: https://github.com/apache/maven-resolver/pull/153#discussion_r810665642
##########
File path: pom.xml
##########
@@ -77,7 +77,7 @@
<guiceVersion>4.2.3</guiceVersion>
<guavaVersion>30.1-jre</guavaVersion>
<guavafailureaccessVersion>1.0.1</guavafailureaccessVersion>
- <slf4jVersion>1.7.32</slf4jVersion>
+ <slf4jVersion>1.7.36</slf4jVersion>
Review comment:
IMHO I think this is not really a requirement. Why should it match core in your opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org