You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by "furqaankhan (via GitHub)" <gi...@apache.org> on 2024/03/26 19:57:19 UTC

[PR] [SEDONA-522] Add ST_Union with array of Geometry as input [sedona]

furqaankhan opened a new pull request, #1294:
URL: https://github.com/apache/sedona/pull/1294

   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/)
   
   ## Is this PR related to a JIRA ticket?
   
   - Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-522. The PR name follows the format `[SEDONA-XXX] my subject`.
   
   ## What changes were proposed in this PR?
   
   - Add ST_Union with Array input
   - Port ST_Union with 2 geometry input to Flink
   
   ## How was this patch tested?
   
   - Passed new and existing tests
   
   ## Did this PR include necessary documentation updates?
   
   - Yes, I have updated the documentation update.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SEDONA-522] Add ST_Union with array of Geometry as input [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #1294:
URL: https://github.com/apache/sedona/pull/1294


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SEDONA-522] Add ST_Union with array of Geometry as input [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #1294:
URL: https://github.com/apache/sedona/pull/1294#discussion_r1540068565


##########
docs/api/sql/Function.md:
##########
@@ -2940,9 +2940,17 @@ POINT (-70.01 44.37)
 
 ## ST_Union
 
-Introduction: Return the union of geometry A and B
+Introduction:
+
+Variant 1: Return the union of geometry A and B.

Review Comment:
   1. Can you also update the ST_H3toGeom and ST_S2toGeom doc to explain how this ST_Union works in conjunction with these functions?
   
   2. What happens to polygons that could not be unioned (polygons that share no boundaries)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SEDONA-522] Add ST_Union with array of Geometry as input [sedona]

Posted by "furqaankhan (via GitHub)" <gi...@apache.org>.
furqaankhan commented on code in PR #1294:
URL: https://github.com/apache/sedona/pull/1294#discussion_r1540074238


##########
docs/api/sql/Function.md:
##########
@@ -2940,9 +2940,17 @@ POINT (-70.01 44.37)
 
 ## ST_Union
 
-Introduction: Return the union of geometry A and B
+Introduction:
+
+Variant 1: Return the union of geometry A and B.

Review Comment:
   1. Sure.
   2. It returns a MultiPolygon with each set of boundaries. See here: https://github.com/apache/sedona/blob/ec6dfff79974a2846ecff5dcdf6a95417a7cb7c9/spark/common/src/test/scala/org/apache/sedona/sql/functionTestScala.scala#L700-L705



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SEDONA-522] Add ST_Union with array of Geometry as input [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #1294:
URL: https://github.com/apache/sedona/pull/1294#discussion_r1540079262


##########
docs/api/sql/Function.md:
##########
@@ -2940,9 +2940,17 @@ POINT (-70.01 44.37)
 
 ## ST_Union
 
-Introduction: Return the union of geometry A and B
+Introduction:
+
+Variant 1: Return the union of geometry A and B.

Review Comment:
   @furqaankhan Cool. Can you also explain this in the doc?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org