[GitHub] spark pull request #22187: [SPARK-25178][SQL] Directly ship the StructType o...

[ueshin <gi...@git.apache.org>]

Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22187#discussion_r212164362
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala ---
    @@ -44,31 +44,8 @@ class RowBasedHashMapGenerator(
         groupingKeySchema, bufferSchema) {
     
       override protected def initializeAggregateHashMap(): String = {
    -    val generatedKeySchema: String =
    -      s"new org.apache.spark.sql.types.StructType()" +
    -        groupingKeySchema.map { key =>
    -          val keyName = ctx.addReferenceObj("keyName", key.name)
    -          key.dataType match {
    -            case d: DecimalType =>
    -              s""".add($keyName, org.apache.spark.sql.types.DataTypes.createDecimalType(
    -                  |${d.precision}, ${d.scale}))""".stripMargin
    -            case _ =>
    -              s""".add($keyName, org.apache.spark.sql.types.DataTypes.${key.dataType})"""
    -          }
    -        }.mkString("\n").concat(";")
    -
    -    val generatedValueSchema: String =
    -      s"new org.apache.spark.sql.types.StructType()" +
    -        bufferSchema.map { key =>
    -          val keyName = ctx.addReferenceObj("keyName", key.name)
    -          key.dataType match {
    -            case d: DecimalType =>
    -              s""".add($keyName, org.apache.spark.sql.types.DataTypes.createDecimalType(
    -                  |${d.precision}, ${d.scale}))""".stripMargin
    -            case _ =>
    -              s""".add($keyName, org.apache.spark.sql.types.DataTypes.${key.dataType})"""
    -          }
    -        }.mkString("\n").concat(";")
    +    val generatedKeySchema = ctx.addReferenceObj("generatedKeySchemaTerm", groupingKeySchema)
    --- End diff --
    
    nit: the variable name sounds strange because the schema is not generated any more.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org