You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/12/08 20:06:39 UTC
[GitHub] oliviermichaelis commented on a change in pull request #6504:
Enhance Docker
oliviermichaelis commented on a change in pull request #6504: Enhance Docker
URL: https://github.com/apache/incubator-superset/pull/6504#discussion_r240014999
##########
File path: contrib/docker/docker-compose.yml
##########
@@ -31,11 +35,12 @@ services:
POSTGRES_PORT: 5432
REDIS_HOST: redis
REDIS_PORT: 6379
+ SUPERSET_PORT: # Set port in .env file
# If using production, comment development volume below
#SUPERSET_ENV: production
SUPERSET_ENV: development
ports:
- - 8088:8088
+ - ${SUPERSET_PORT}:${SUPERSET_PORT}
Review comment:
@victornoel you are right, I wasn't thinking about the possibility to map a different host port to the container. Thanks for the feedback! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org