You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Robert Burke (Jira)" <ji...@apache.org> on 2021/09/27 16:33:00 UTC
[jira] [Updated] (BEAM-6958) Split Go PostCommit Test results by
Runner
[ https://issues.apache.org/jira/browse/BEAM-6958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Burke updated BEAM-6958:
-------------------------------
Assignee: Daniel Oliveira
Resolution: Fixed
Status: Resolved (was: Open)
> Split Go PostCommit Test results by Runner
> ------------------------------------------
>
> Key: BEAM-6958
> URL: https://issues.apache.org/jira/browse/BEAM-6958
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go, testing
> Reporter: Robert Burke
> Assignee: Daniel Oliveira
> Priority: P3
>
> At present the Go SDK only has a single column filled in on the master branch Post-Commit Tests Status testing rubric, which is unclear, and not-ideal.
> Right now the jenkin's [Go PostCommit tests|https://github.com/apache/beam/blob/ec3f79214e9ef204fa32b744051a291fe4b61e23/.test-infra/jenkins/job_PostCommit_Go.groovy#L24] trigger the [go integration test task|https://github.com/apache/beam/blob/58a70b273367c22fd7c8562c42bc10a07dbe7156/build.gradle#L178], which only runs the [tests on Dataflow via a shell script|https://github.com/apache/beam/blob/master/sdks/go/test/run_integration_tests.sh#L78]. It doesn't even run the unit tests as per the pre-commit.
> The end goal for this task is to:
> * Have the Go SDK column represent the Go SDK Unit Tests as a post commit.
> * Or better, to avoid pre-commit-run duplication, run the integration tests against the ULR if other runners are doing so.
> * Have the integration tests run against the Dataflow, be represented in the column.
> This will set the basis for adding and the integration tests against other portable runners (Flink, Spark, Python ULR, future portable runners...)
> It looks like there are three bits of work to accomplish here:
> * Adjust the Gradle tasks/task names to accurately represent what they're running against.
> * Add the new Jenkins tasks for each of the runners. (The other languages call these ValidateRunner_<RUNNER> tasks),
> * Add the cool "badges" to the new Jenkins tasks to the Post Commit rubric.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)