You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/24 21:03:52 UTC

[GitHub] [tvm] CircleSpin opened a new pull request #7739: [TVMC] Externalize load from compile_module (compiler.py line 132)

CircleSpin opened a new pull request #7739:
URL: https://github.com/apache/tvm/pull/7739


   This PR moves the load component from compile_module to drive_compile to make it cleaner for python scripting. It prevents "double dipping" the load in frontends more than once. 
   The flow is now 
   1. mod, params = tvmc.load("whatever") #from frontends.py
   2. lib, etc = tvmc.compile(mod, params) #from compiler.py
   
   See PR #7698 for import details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] comaniac commented on pull request #7739: [TVMC] Externalize load from compile_module (compiler.py line 132)

Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7739:
URL: https://github.com/apache/tvm/pull/7739#issuecomment-806190266


   I'm fine with this change. Leave on others.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] CircleSpin commented on pull request #7739: [TVMC] Externalize load from compile_module (compiler.py line 132)

Posted by GitBox <gi...@apache.org>.
CircleSpin commented on pull request #7739:
URL: https://github.com/apache/tvm/pull/7739#issuecomment-806185373


   @comaniac @mdw-octoml @leandron @jwfromm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] jwfromm merged pull request #7739: [TVMC] Separate model loading from model compilation in TVMC.

Posted by GitBox <gi...@apache.org>.
jwfromm merged pull request #7739:
URL: https://github.com/apache/tvm/pull/7739


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] jwfromm commented on pull request #7739: [TVMC] Separate model loading from model compilation in TVMC.

Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7739:
URL: https://github.com/apache/tvm/pull/7739#issuecomment-812610024


   Thanks @CircleSpin, @comaniac, and @leandron. This is now merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org