You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@freemarker.apache.org by Jacopo Cappellato <ja...@gmail.com> on 2017/01/23 08:00:04 UTC

Re: incubator-freemarker-docgen git commit: Changed footer layout to accept arbitrary long copyright text. Added copyrightSuffix setting, where you can add the trademark notes and such.

On Fri, Jan 6, 2017 at 8:39 PM, <dd...@apache.org> wrote:

> Repository: incubator-freemarker-docgen
> Updated Branches:
>   refs/heads/master 05ddf9339 -> f968b192e
>
>
> Changed footer layout to accept arbitrary long copyright text. Added
> copyrightSuffix setting, where you can add the trademark notes and such.
> [...]
>
> http://git-wip-us.apache.org/repos/asf/incubator-freemarker-docgen/blob/
> f968b192/src/main/org/freemarker/docgen/templates/footer.ftlh
> ----------------------------------------------------------------------
> diff --git a/src/main/org/freemarker/docgen/templates/footer.ftlh
> b/src/main/org/freemarker/docgen/templates/footer.ftlh
> index ac43e17..29d9a27 100644
> --- a/src/main/org/freemarker/docgen/templates/footer.ftlh
> +++ b/src/main/org/freemarker/docgen/templates/footer.ftlh
>
> @@ -73,7 +72,8 @@
>    <p class="copyright">
>      © <span itemprop="copyrightYear">${copyrightStartYear?string('0')
> }</span><#rt>
>      <#lt><#if transformStartTime?string('yyyy')?number !=
> copyrightStartYear>–${transformStartTime?string('yyyy')}</#if>
> -    <a itemtype="http://schema.org/Organization"
> itemprop="copyrightHolder" href="http://freemarker.org">${copyrightHolder}</a>.
> All rights reserved.<#t>
> +    <a itemtype="http://schema.org/Organization"
> itemprop="copyrightHolder" href="http://freemarker.org">$
> {copyrightHolder}</a><#t>
> +    <#if copyrightSuffix??>. ${copyrightSuffix}</#if><#t>
>    </p>
>  </#macro>
>

This is minor but I think we should change the url of the "copyright
holder" from freemarker.org to apache.org.

Jacopo

Re: incubator-freemarker-docgen git commit: Changed footer layout to accept arbitrary long copyright text. Added copyrightSuffix setting, where you can add the trademark notes and such.

Posted by Daniel Dekany <dd...@freemail.hu>.
Thanks, I have fixed this!


Monday, January 23, 2017, 9:00:04 AM, Jacopo Cappellato wrote:

> On Fri, Jan 6, 2017 at 8:39 PM, <dd...@apache.org> wrote:
>
>> Repository: incubator-freemarker-docgen
>> Updated Branches:
>>   refs/heads/master 05ddf9339 -> f968b192e
>>
>>
>> Changed footer layout to accept arbitrary long copyright text. Added
>> copyrightSuffix setting, where you can add the trademark notes and such.
>> [...]
>>
>> http://git-wip-us.apache.org/repos/asf/incubator-freemarker-docgen/blob/
>> f968b192/src/main/org/freemarker/docgen/templates/footer.ftlh
>> ----------------------------------------------------------------------
>> diff --git a/src/main/org/freemarker/docgen/templates/footer.ftlh
>> b/src/main/org/freemarker/docgen/templates/footer.ftlh
>> index ac43e17..29d9a27 100644
>> --- a/src/main/org/freemarker/docgen/templates/footer.ftlh
>> +++ b/src/main/org/freemarker/docgen/templates/footer.ftlh
>>
>> @@ -73,7 +72,8 @@
>>    <p class="copyright">
>>      � <span itemprop="copyrightYear">${copyrightStartYear?string('0')
>> }</span><#rt>
>>      <#lt><#if transformStartTime?string('yyyy')?number !=
>> copyrightStartYear>\u2013${transformStartTime?string('yyyy')}</#if>
>> -    <a itemtype="http://schema.org/Organization"
>> itemprop="copyrightHolder" href="http://freemarker.org">${copyrightHolder}</a>.
>> All rights reserved.<#t>
>> +    <a itemtype="http://schema.org/Organization"
>> itemprop="copyrightHolder" href="http://freemarker.org">$
>> {copyrightHolder}</a><#t>
>> +    <#if copyrightSuffix??>. ${copyrightSuffix}</#if><#t>
>>    </p>
>>  </#macro>
>>
>
> This is minor but I think we should change the url of the "copyright
> holder" from freemarker.org to apache.org.
>
> Jacopo

-- 
Thanks,
 Daniel Dekany