[jira] [Commented] (FLINK-4086) Hide internal Expression methods from Table API

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361475#comment-15361475 ] 

ASF GitHub Bot commented on FLINK-4086:
---------------------------------------

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/2126
  
    Thanks @fhueske. I will rebase and review your PR.


> Hide internal Expression methods from Table API
> -----------------------------------------------
>
>                 Key: FLINK-4086
>                 URL: https://issues.apache.org/jira/browse/FLINK-4086
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.1.0
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>             Fix For: 1.1.0
>
>
> Internal methods are accessible from the Table API expressions.
> For instance it is possible to call:
> {code}
> val table: Table = ???
> table.select('name.toRexNode(), ('age + 10).validateInput())
> {code}
> We should hide internal methods like {{toRexNode()}} and {{validateInput()}} from the API.
> I propose to restrict access to this methods to objects in the {{org.apache.flink}} name space via a {{private\[flink\]}} access modifier.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)