[GitHub] [cassandra] bereng commented on a change in pull request #706: CASSANDRA-16003 Improve tooling stdErr checks

[GitBox <gi...@apache.org>]

bereng commented on a change in pull request #706:
URL: https://github.com/apache/cassandra/pull/706#discussion_r464307542



##########
File path: test/unit/org/apache/cassandra/tools/ToolRunner.java
##########
@@ -330,12 +330,21 @@ public ToolRunner waitAndAssertOnExitCode()
     
     public ToolRunner waitAndAssertOnCleanExit()
     {
-        return waitAndAssertOnExitCode().assertEmptyStdErr();
+        return waitAndAssertOnExitCode().assertCleanStdErr();
     }
     
-    public ToolRunner assertEmptyStdErr()
+    /**
+     * Checks if the stdErr is empty after removing any JVM env info output
+     * 
+     * Some JVM configs may output env info on stdErr. We need to remove those to see what was the tool's actual stdErr
+     * 
+     * @return
+     */
+    public ToolRunner assertCleanStdErr()

Review comment:
       Aha! icywm. Iiuc my latest commit works off an exclude list. I haven't gone as far as implementing the `grepLog` functionality as it sounds more like sthg for another ticket + I want to merger this asap bc of 15583 (the main tooling ticket).
   
   Still I think this addition is nice and a step in the direction you point. Wdyt?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org